[ewg] Re: [PATCH ofed-1.2-rc3 2/4] ehca: backport for rhel-4.5 - mmap functonality

[Michael S. Tsirkin]

Some questions:

+diff -Nurp ofa_kernel-1.2_old/drivers/infiniband/hw/ehca/ehca_main.c ofa_kernel-1.2_new/drivers/infiniband/hw/ehca/ehca_main.c
+--- ofa_kernel-1.2_old/drivers/infiniband/hw/ehca/ehca_main.c	2007-05-04 10:38:23.000000000 +0200
++++ ofa_kernel-1.2_new/drivers/infiniband/hw/ehca/ehca_main.c	2007-05-04 10:40:06.000000000 +0200
+@@ -52,7 +52,7 @@
+ MODULE_LICENSE("Dual BSD/GPL");
+ MODULE_AUTHOR("Christoph Raisch <raisch at de.ibm.com>");
+ MODULE_DESCRIPTION("IBM eServer HCA InfiniBand Device Driver");
+-MODULE_VERSION("SVNEHCA_0022");
++MODULE_VERSION("SVNEHCA_0019");
+ 
+ int ehca_open_aqp1     = 0;
+ int ehca_debug_level   = 0;

Is this intentional?

+@@ -293,7 +293,7 @@ int ehca_init_device(struct ehca_shca *s
+ 	strlcpy(shca->ib_device.name, "ehca%d", IB_DEVICE_NAME_MAX);
+ 	shca->ib_device.owner               = THIS_MODULE;
+ 
+-	shca->ib_device.uverbs_abi_ver	    = 6;
++	shca->ib_device.uverbs_abi_ver	    = 5;
+ 	shca->ib_device.uverbs_cmd_mask	    =
+ 		(1ull << IB_USER_VERBS_CMD_GET_CONTEXT)		|
+ 		(1ull << IB_USER_VERBS_CMD_QUERY_DEVICE)	|
+@@ -357,7 +357,7 @@ int ehca_init_device(struct ehca_shca *s
+ 	shca->ib_device.dealloc_fmr	    = ehca_dealloc_fmr;
+ 	shca->ib_device.attach_mcast	    = ehca_attach_mcast;
+ 	shca->ib_device.detach_mcast	    = ehca_detach_mcast;
+-	/* shca->ib_device.process_mad	    = ehca_process_mad;     */
++	/* shca->ib_device.process_mad	    = ehca_process_mad;	    */
+ 	shca->ib_device.mmap		    = ehca_mmap;
+ 
+ 	return ret;

Is this really necessary?

+@@ -811,7 +811,7 @@ int __init ehca_module_init(void)
+ 	int ret;
+ 
+ 	printk(KERN_INFO "eHCA Infiniband Device Driver "
+-	                 "(Rel.: SVNEHCA_0022)\n");
++	                 "(Rel.: SVNEHCA_0019)\n");
+ 	idr_init(&ehca_qp_idr);
+ 	idr_init(&ehca_cq_idr);
+ 	spin_lock_init(&ehca_qp_idr_lock);

Is this intentional?


-- 
MST