[ewg] RE: [PATCH 2/2] IB/iser: add backport & kerneladdons foropen-iscsiover iSER support for RHAS4 up3 and up4

[Erez Zilber]

>> It will also require ugly
>> adjustments like:
>>
>> kernel_patches/backport/2.6.9_U3/iscsi_scsi_addons.patch:
>>
>> diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile
>> index e212608..3bf2015 100644
>> --- a/drivers/scsi/Makefile
>> +++ b/drivers/scsi/Makefile
>> @@ -1,2 +1,7 @@
>>  obj-$(CONFIG_SCSI_ISCSI_ATTRS) += scsi_transport_iscsi.o
>>  obj-$(CONFIG_ISCSI_TCP)        += libiscsi.o   iscsi_tcp.o
>> +
>> +CFLAGS_attribute_container.o = 
>> -I$(PWD)/kernel_addons/backport/2.6.9_U3/include/src/
>> +
>> +scsi_transport_iscsi-y := scsi_transport_iscsi_f.o scsi.o scsi_lib.o
>> init.o klist.o attribute_container.o transport_class.o
>> +libiscsi-y             := libiscsi_f.o scsi_scan.o
>>
>> (because base.h is in kernel_addons/backport/2.6.9_U3/include/src)
>
> This is one approach, and I think it's not too bad.
> Alternative is to use the relative path for include directive:
> #include "../drivers/base/attribute_container.c"
> 
> Wouldn't this work?

I am doing that. However, attribute_container.c includes base.h which is in the kernel_addons dir. Since attribute_container.c is no longer there, I need to add the following line:
 
-I$(PWD)/kernel_addons/backport/2.6.9_U3/include/src/
 
It is not very very ugly, so I think that we can do that. I will make the required fixes according to this approach.
 
Erez