[ewg] printk in ofed-1.3 ib_destroy_qp()

Steve Wise swise at opengridcomputing.com
Tue Nov 6 11:45:42 PST 2007


Should this printk be here?

> int ib_destroy_qp(struct ib_qp *qp)
> {
>         struct ib_pd *pd;
>         struct ib_cq *scq, *rcq;
>         struct ib_srq *srq;
>         struct ib_xrcd *xrcd;
>         enum ib_qp_type qp_type = qp->qp_type;
>         int ret;
> 
>         pd  = qp->pd;
>         scq = qp->send_cq;
>         rcq = qp->recv_cq;
>         srq = qp->srq;
>         xrcd = qp->xrcd;
> 
>         ret = qp->device->destroy_qp(qp);
>         if (!ret) {
>                 atomic_dec(&pd->usecnt);
>                 atomic_dec(&scq->usecnt);
>                 atomic_dec(&rcq->usecnt);
>                 if (srq)
>                         atomic_dec(&srq->usecnt);
>                 if (qp_type == IB_QPT_XRC)
>                         atomic_dec(&xrcd->usecnt);
>                 else
>                         printk("ib_destroy_qp: type = %d, xrcd = %p\n", qp_type, xrcd);
>         }
> 
>         return ret;
> }



More information about the ewg mailing list