[ewg] RE: [ofa-general] [PATCH 0/6] nes: Cosmetic changes; support virtual WQs and PPC
Glenn Grundstrom
ggrundstrom at NetEffect.com
Tue Nov 27 17:39:59 PST 2007
Or you said I could submit patches to you. One problem with
only using your tree is that I need to supply updates and backports
for OFED builds. I've cloned Vlad's tree for that.
How about this for the future: Let me know when you've made
changes and I'll pull and merge your changes into my code.
That way I can still provide everything for OFED and patches
I create should apply cleanly in your branch. I assume
you could also pull from my tree as well, right? If you have
a better way to satisfy all we can discuss it.
The last set of patches were 99% cosmetic changes and I
shouldn't need to submit something that unwieldy again.
On that note, I've got another set of patches almost ready to
go and I've split them by issue/fix. Maybe you should wait to
modify anything in the nes directory until I've pushed my changes
to the OFA servers.
Sorry for the mixup.
Thanks,
Glenn.
>
> Arghh... these don't apply to my "neteffect" branch, so you've lost
> the cleanup work that I did (eg trailing whitespace removal,
> formatting fixes, etc). I thought we agreed that I would pull the
> driver into my tree for merging into 2.6.25 and we would work on it
> there.
>
> Anwyay. I'll reimport the nes driver into a new "neteffect" branch in
> my tree (and maybe recreate the work I did). In the future please
> post updates as incremental patches to that tree. And when I say
> incremental patches I mean reviewable things that are split up
> conceptually and not by which files they touch. (That is, patches
> like "Fix types of workqueue work functions" rather than "Fix
> nes_cm.c")
>
> Thanks...
>
More information about the ewg
mailing list