[ewg] [PATCH 1/8 warnings] Fix warnings on ppc64

Jeremy Brown jeremy.brown at qlogic.com
Fri Oct 5 16:47:20 PDT 2007


Tziporet, Vlad,

This is the first of eight patches that fix compiler warnings that we
discussed in the 24 Sep 2007 call. Please include it in OFED 1.3.

Thanks!

Jeremy Brown

---

No need to take address of an array to pass a ptr.  Caused warnings on powerpc.

Signed-off-by: John Gregor <john.gregor at qlogic.com>

diff -r cc2f5381a47f kernel_addons/backport/2.6.11/include/src/genalloc.c
--- a/kernel_addons/backport/2.6.11/include/src/genalloc.c	Thu May 10 20:50:14 2007 -0700
+++ b/kernel_addons/backport/2.6.11/include/src/genalloc.c	Thu May 10 22:06:06 2007 -0700
@@ -148,7 +148,7 @@ unsigned long gen_pool_alloc(struct gen_
 			addr = chunk->start_addr +
 					    ((unsigned long)start_bit << order);
 			while (nbits--)
-				__set_bit(start_bit++, &chunk->bits);
+				__set_bit(start_bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			read_unlock(&pool->lock);
 			return addr;
@@ -187,7 +187,7 @@ void gen_pool_free(struct gen_pool *pool
 			spin_lock_irqsave(&chunk->lock, flags);
 			bit = (addr - chunk->start_addr) >> order;
 			while (nbits--)
-				__clear_bit(bit++, &chunk->bits);
+				__clear_bit(bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			break;
 		}
diff -r cc2f5381a47f kernel_addons/backport/2.6.12/include/src/genalloc.c
--- a/kernel_addons/backport/2.6.12/include/src/genalloc.c	Thu May 10 20:50:14 2007 -0700
+++ b/kernel_addons/backport/2.6.12/include/src/genalloc.c	Thu May 10 22:06:06 2007 -0700
@@ -148,7 +148,7 @@ unsigned long gen_pool_alloc(struct gen_
 			addr = chunk->start_addr +
 					    ((unsigned long)start_bit << order);
 			while (nbits--)
-				__set_bit(start_bit++, &chunk->bits);
+				__set_bit(start_bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			read_unlock(&pool->lock);
 			return addr;
@@ -187,7 +187,7 @@ void gen_pool_free(struct gen_pool *pool
 			spin_lock_irqsave(&chunk->lock, flags);
 			bit = (addr - chunk->start_addr) >> order;
 			while (nbits--)
-				__clear_bit(bit++, &chunk->bits);
+				__clear_bit(bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			break;
 		}
diff -r cc2f5381a47f kernel_addons/backport/2.6.13/include/src/genalloc.c
--- a/kernel_addons/backport/2.6.13/include/src/genalloc.c	Thu May 10 20:50:14 2007 -0700
+++ b/kernel_addons/backport/2.6.13/include/src/genalloc.c	Thu May 10 22:06:06 2007 -0700
@@ -148,7 +148,7 @@ unsigned long gen_pool_alloc(struct gen_
 			addr = chunk->start_addr +
 					    ((unsigned long)start_bit << order);
 			while (nbits--)
-				__set_bit(start_bit++, &chunk->bits);
+				__set_bit(start_bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			read_unlock(&pool->lock);
 			return addr;
@@ -187,7 +187,7 @@ void gen_pool_free(struct gen_pool *pool
 			spin_lock_irqsave(&chunk->lock, flags);
 			bit = (addr - chunk->start_addr) >> order;
 			while (nbits--)
-				__clear_bit(bit++, &chunk->bits);
+				__clear_bit(bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			break;
 		}
diff -r cc2f5381a47f kernel_addons/backport/2.6.14/include/src/genalloc.c
--- a/kernel_addons/backport/2.6.14/include/src/genalloc.c	Thu May 10 20:50:14 2007 -0700
+++ b/kernel_addons/backport/2.6.14/include/src/genalloc.c	Thu May 10 22:06:06 2007 -0700
@@ -148,7 +148,7 @@ unsigned long gen_pool_alloc(struct gen_
 			addr = chunk->start_addr +
 					    ((unsigned long)start_bit << order);
 			while (nbits--)
-				__set_bit(start_bit++, &chunk->bits);
+				__set_bit(start_bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			read_unlock(&pool->lock);
 			return addr;
@@ -187,7 +187,7 @@ void gen_pool_free(struct gen_pool *pool
 			spin_lock_irqsave(&chunk->lock, flags);
 			bit = (addr - chunk->start_addr) >> order;
 			while (nbits--)
-				__clear_bit(bit++, &chunk->bits);
+				__clear_bit(bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			break;
 		}
diff -r cc2f5381a47f kernel_addons/backport/2.6.15/include/src/genalloc.c
--- a/kernel_addons/backport/2.6.15/include/src/genalloc.c	Thu May 10 20:50:14 2007 -0700
+++ b/kernel_addons/backport/2.6.15/include/src/genalloc.c	Thu May 10 22:06:06 2007 -0700
@@ -148,7 +148,7 @@ unsigned long gen_pool_alloc(struct gen_
 			addr = chunk->start_addr +
 					    ((unsigned long)start_bit << order);
 			while (nbits--)
-				__set_bit(start_bit++, &chunk->bits);
+				__set_bit(start_bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			read_unlock(&pool->lock);
 			return addr;
@@ -187,7 +187,7 @@ void gen_pool_free(struct gen_pool *pool
 			spin_lock_irqsave(&chunk->lock, flags);
 			bit = (addr - chunk->start_addr) >> order;
 			while (nbits--)
-				__clear_bit(bit++, &chunk->bits);
+				__clear_bit(bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			break;
 		}
diff -r cc2f5381a47f kernel_addons/backport/2.6.15_ubuntu606/include/src/genalloc.c
--- a/kernel_addons/backport/2.6.15_ubuntu606/include/src/genalloc.c	Thu May 10 20:50:14 2007 -0700
+++ b/kernel_addons/backport/2.6.15_ubuntu606/include/src/genalloc.c	Thu May 10 22:06:06 2007 -0700
@@ -148,7 +148,7 @@ unsigned long gen_pool_alloc(struct gen_
 			addr = chunk->start_addr +
 					    ((unsigned long)start_bit << order);
 			while (nbits--)
-				__set_bit(start_bit++, &chunk->bits);
+				__set_bit(start_bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			read_unlock(&pool->lock);
 			return addr;
@@ -187,7 +187,7 @@ void gen_pool_free(struct gen_pool *pool
 			spin_lock_irqsave(&chunk->lock, flags);
 			bit = (addr - chunk->start_addr) >> order;
 			while (nbits--)
-				__clear_bit(bit++, &chunk->bits);
+				__clear_bit(bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			break;
 		}
diff -r cc2f5381a47f kernel_addons/backport/2.6.16/include/src/genalloc.c
--- a/kernel_addons/backport/2.6.16/include/src/genalloc.c	Thu May 10 20:50:14 2007 -0700
+++ b/kernel_addons/backport/2.6.16/include/src/genalloc.c	Thu May 10 22:06:06 2007 -0700
@@ -148,7 +148,7 @@ unsigned long gen_pool_alloc(struct gen_
 			addr = chunk->start_addr +
 					    ((unsigned long)start_bit << order);
 			while (nbits--)
-				__set_bit(start_bit++, &chunk->bits);
+				__set_bit(start_bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			read_unlock(&pool->lock);
 			return addr;
@@ -187,7 +187,7 @@ void gen_pool_free(struct gen_pool *pool
 			spin_lock_irqsave(&chunk->lock, flags);
 			bit = (addr - chunk->start_addr) >> order;
 			while (nbits--)
-				__clear_bit(bit++, &chunk->bits);
+				__clear_bit(bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			break;
 		}
diff -r cc2f5381a47f kernel_addons/backport/2.6.16_sles10/include/src/genalloc.c
--- a/kernel_addons/backport/2.6.16_sles10/include/src/genalloc.c	Thu May 10 20:50:14 2007 -0700
+++ b/kernel_addons/backport/2.6.16_sles10/include/src/genalloc.c	Thu May 10 22:06:06 2007 -0700
@@ -148,7 +148,7 @@ unsigned long gen_pool_alloc(struct gen_
 			addr = chunk->start_addr +
 					    ((unsigned long)start_bit << order);
 			while (nbits--)
-				__set_bit(start_bit++, &chunk->bits);
+				__set_bit(start_bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			read_unlock(&pool->lock);
 			return addr;
@@ -187,7 +187,7 @@ void gen_pool_free(struct gen_pool *pool
 			spin_lock_irqsave(&chunk->lock, flags);
 			bit = (addr - chunk->start_addr) >> order;
 			while (nbits--)
-				__clear_bit(bit++, &chunk->bits);
+				__clear_bit(bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			break;
 		}
diff -r cc2f5381a47f kernel_addons/backport/2.6.16_sles10_sp1/include/src/genalloc.c
--- a/kernel_addons/backport/2.6.16_sles10_sp1/include/src/genalloc.c	Thu May 10 20:50:14 2007 -0700
+++ b/kernel_addons/backport/2.6.16_sles10_sp1/include/src/genalloc.c	Thu May 10 22:06:06 2007 -0700
@@ -148,7 +148,7 @@ unsigned long gen_pool_alloc(struct gen_
 			addr = chunk->start_addr +
 					    ((unsigned long)start_bit << order);
 			while (nbits--)
-				__set_bit(start_bit++, &chunk->bits);
+				__set_bit(start_bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			read_unlock(&pool->lock);
 			return addr;
@@ -187,7 +187,7 @@ void gen_pool_free(struct gen_pool *pool
 			spin_lock_irqsave(&chunk->lock, flags);
 			bit = (addr - chunk->start_addr) >> order;
 			while (nbits--)
-				__clear_bit(bit++, &chunk->bits);
+				__clear_bit(bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			break;
 		}
diff -r cc2f5381a47f kernel_addons/backport/2.6.17/include/src/genalloc.c
--- a/kernel_addons/backport/2.6.17/include/src/genalloc.c	Thu May 10 20:50:14 2007 -0700
+++ b/kernel_addons/backport/2.6.17/include/src/genalloc.c	Thu May 10 22:06:06 2007 -0700
@@ -148,7 +148,7 @@ unsigned long gen_pool_alloc(struct gen_
 			addr = chunk->start_addr +
 					    ((unsigned long)start_bit << order);
 			while (nbits--)
-				__set_bit(start_bit++, &chunk->bits);
+				__set_bit(start_bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			read_unlock(&pool->lock);
 			return addr;
@@ -187,7 +187,7 @@ void gen_pool_free(struct gen_pool *pool
 			spin_lock_irqsave(&chunk->lock, flags);
 			bit = (addr - chunk->start_addr) >> order;
 			while (nbits--)
-				__clear_bit(bit++, &chunk->bits);
+				__clear_bit(bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			break;
 		}
diff -r cc2f5381a47f kernel_addons/backport/2.6.18/include/src/genalloc.c
--- a/kernel_addons/backport/2.6.18/include/src/genalloc.c	Thu May 10 20:50:14 2007 -0700
+++ b/kernel_addons/backport/2.6.18/include/src/genalloc.c	Thu May 10 22:06:06 2007 -0700
@@ -148,7 +148,7 @@ unsigned long gen_pool_alloc(struct gen_
 			addr = chunk->start_addr +
 					    ((unsigned long)start_bit << order);
 			while (nbits--)
-				__set_bit(start_bit++, &chunk->bits);
+				__set_bit(start_bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			read_unlock(&pool->lock);
 			return addr;
@@ -187,7 +187,7 @@ void gen_pool_free(struct gen_pool *pool
 			spin_lock_irqsave(&chunk->lock, flags);
 			bit = (addr - chunk->start_addr) >> order;
 			while (nbits--)
-				__clear_bit(bit++, &chunk->bits);
+				__clear_bit(bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			break;
 		}
diff -r cc2f5381a47f kernel_addons/backport/2.6.18_FC6/include/src/genalloc.c
--- a/kernel_addons/backport/2.6.18_FC6/include/src/genalloc.c	Thu May 10 20:50:14 2007 -0700
+++ b/kernel_addons/backport/2.6.18_FC6/include/src/genalloc.c	Thu May 10 22:06:06 2007 -0700
@@ -148,7 +148,7 @@ unsigned long gen_pool_alloc(struct gen_
 			addr = chunk->start_addr +
 					    ((unsigned long)start_bit << order);
 			while (nbits--)
-				__set_bit(start_bit++, &chunk->bits);
+				__set_bit(start_bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			read_unlock(&pool->lock);
 			return addr;
@@ -187,7 +187,7 @@ void gen_pool_free(struct gen_pool *pool
 			spin_lock_irqsave(&chunk->lock, flags);
 			bit = (addr - chunk->start_addr) >> order;
 			while (nbits--)
-				__clear_bit(bit++, &chunk->bits);
+				__clear_bit(bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			break;
 		}
diff -r cc2f5381a47f kernel_addons/backport/2.6.19/include/src/genalloc.c
--- a/kernel_addons/backport/2.6.19/include/src/genalloc.c	Thu May 10 20:50:14 2007 -0700
+++ b/kernel_addons/backport/2.6.19/include/src/genalloc.c	Thu May 10 22:06:06 2007 -0700
@@ -148,7 +148,7 @@ unsigned long gen_pool_alloc(struct gen_
 			addr = chunk->start_addr +
 					    ((unsigned long)start_bit << order);
 			while (nbits--)
-				__set_bit(start_bit++, &chunk->bits);
+				__set_bit(start_bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			read_unlock(&pool->lock);
 			return addr;
@@ -187,7 +187,7 @@ void gen_pool_free(struct gen_pool *pool
 			spin_lock_irqsave(&chunk->lock, flags);
 			bit = (addr - chunk->start_addr) >> order;
 			while (nbits--)
-				__clear_bit(bit++, &chunk->bits);
+				__clear_bit(bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			break;
 		}
diff -r cc2f5381a47f kernel_addons/backport/2.6.20/include/src/genalloc.c
--- a/kernel_addons/backport/2.6.20/include/src/genalloc.c	Thu May 10 20:50:14 2007 -0700
+++ b/kernel_addons/backport/2.6.20/include/src/genalloc.c	Thu May 10 22:06:06 2007 -0700
@@ -148,7 +148,7 @@ unsigned long gen_pool_alloc(struct gen_
 			addr = chunk->start_addr +
 					    ((unsigned long)start_bit << order);
 			while (nbits--)
-				__set_bit(start_bit++, &chunk->bits);
+				__set_bit(start_bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			read_unlock(&pool->lock);
 			return addr;
@@ -187,7 +187,7 @@ void gen_pool_free(struct gen_pool *pool
 			spin_lock_irqsave(&chunk->lock, flags);
 			bit = (addr - chunk->start_addr) >> order;
 			while (nbits--)
-				__clear_bit(bit++, &chunk->bits);
+				__clear_bit(bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			break;
 		}
diff -r cc2f5381a47f kernel_addons/backport/2.6.5_sles9_sp3/include/src/genalloc.c
--- a/kernel_addons/backport/2.6.5_sles9_sp3/include/src/genalloc.c	Thu May 10 20:50:14 2007 -0700
+++ b/kernel_addons/backport/2.6.5_sles9_sp3/include/src/genalloc.c	Thu May 10 22:06:06 2007 -0700
@@ -148,7 +148,7 @@ unsigned long gen_pool_alloc(struct gen_
 			addr = chunk->start_addr +
 					    ((unsigned long)start_bit << order);
 			while (nbits--)
-				__set_bit(start_bit++, &chunk->bits);
+				__set_bit(start_bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			read_unlock(&pool->lock);
 			return addr;
@@ -187,7 +187,7 @@ void gen_pool_free(struct gen_pool *pool
 			spin_lock_irqsave(&chunk->lock, flags);
 			bit = (addr - chunk->start_addr) >> order;
 			while (nbits--)
-				__clear_bit(bit++, &chunk->bits);
+				__clear_bit(bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			break;
 		}
diff -r cc2f5381a47f kernel_addons/backport/2.6.9_U2/include/src/genalloc.c
--- a/kernel_addons/backport/2.6.9_U2/include/src/genalloc.c	Thu May 10 20:50:14 2007 -0700
+++ b/kernel_addons/backport/2.6.9_U2/include/src/genalloc.c	Thu May 10 22:06:06 2007 -0700
@@ -148,7 +148,7 @@ unsigned long gen_pool_alloc(struct gen_
 			addr = chunk->start_addr +
 					    ((unsigned long)start_bit << order);
 			while (nbits--)
-				__set_bit(start_bit++, &chunk->bits);
+				__set_bit(start_bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			read_unlock(&pool->lock);
 			return addr;
@@ -187,7 +187,7 @@ void gen_pool_free(struct gen_pool *pool
 			spin_lock_irqsave(&chunk->lock, flags);
 			bit = (addr - chunk->start_addr) >> order;
 			while (nbits--)
-				__clear_bit(bit++, &chunk->bits);
+				__clear_bit(bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			break;
 		}
diff -r cc2f5381a47f kernel_addons/backport/2.6.9_U3/include/src/genalloc.c
--- a/kernel_addons/backport/2.6.9_U3/include/src/genalloc.c	Thu May 10 20:50:14 2007 -0700
+++ b/kernel_addons/backport/2.6.9_U3/include/src/genalloc.c	Thu May 10 22:06:06 2007 -0700
@@ -148,7 +148,7 @@ unsigned long gen_pool_alloc(struct gen_
 			addr = chunk->start_addr +
 					    ((unsigned long)start_bit << order);
 			while (nbits--)
-				__set_bit(start_bit++, &chunk->bits);
+				__set_bit(start_bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			read_unlock(&pool->lock);
 			return addr;
@@ -187,7 +187,7 @@ void gen_pool_free(struct gen_pool *pool
 			spin_lock_irqsave(&chunk->lock, flags);
 			bit = (addr - chunk->start_addr) >> order;
 			while (nbits--)
-				__clear_bit(bit++, &chunk->bits);
+				__clear_bit(bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			break;
 		}
diff -r cc2f5381a47f kernel_addons/backport/2.6.9_U4/include/src/genalloc.c
--- a/kernel_addons/backport/2.6.9_U4/include/src/genalloc.c	Thu May 10 20:50:14 2007 -0700
+++ b/kernel_addons/backport/2.6.9_U4/include/src/genalloc.c	Thu May 10 22:06:06 2007 -0700
@@ -148,7 +148,7 @@ unsigned long gen_pool_alloc(struct gen_
 			addr = chunk->start_addr +
 					    ((unsigned long)start_bit << order);
 			while (nbits--)
-				__set_bit(start_bit++, &chunk->bits);
+				__set_bit(start_bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			read_unlock(&pool->lock);
 			return addr;
@@ -187,7 +187,7 @@ void gen_pool_free(struct gen_pool *pool
 			spin_lock_irqsave(&chunk->lock, flags);
 			bit = (addr - chunk->start_addr) >> order;
 			while (nbits--)
-				__clear_bit(bit++, &chunk->bits);
+				__clear_bit(bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			break;
 		}
diff -r cc2f5381a47f kernel_addons/backport/2.6.9_U5/include/src/genalloc.c
--- a/kernel_addons/backport/2.6.9_U5/include/src/genalloc.c	Thu May 10 20:50:14 2007 -0700
+++ b/kernel_addons/backport/2.6.9_U5/include/src/genalloc.c	Thu May 10 22:06:06 2007 -0700
@@ -148,7 +148,7 @@ unsigned long gen_pool_alloc(struct gen_
 			addr = chunk->start_addr +
 					    ((unsigned long)start_bit << order);
 			while (nbits--)
-				__set_bit(start_bit++, &chunk->bits);
+				__set_bit(start_bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			read_unlock(&pool->lock);
 			return addr;
@@ -187,7 +187,7 @@ void gen_pool_free(struct gen_pool *pool
 			spin_lock_irqsave(&chunk->lock, flags);
 			bit = (addr - chunk->start_addr) >> order;
 			while (nbits--)
-				__clear_bit(bit++, &chunk->bits);
+				__clear_bit(bit++, chunk->bits);
 			spin_unlock_irqrestore(&chunk->lock, flags);
 			break;
 		}





More information about the ewg mailing list