[ewg] [PATCH 0/9] [RFC] Support for Xsigo core services (xscore)

[Roland Dreier]

A few quick comments -- I'll look at this in more depth once I've
cleared my backlog of things already submitted.

 - This is an awful lot of code for "core services".  Am I understanding
   correctly that this doesn't do anything that a user is actually wants
   without even more code layered on top?

 - checkpatch.pl reports:

    total: 49 errors, 121 warnings, 6439 lines checked

   it would be nice to get the obvious problems cleared up (eg trailing
   whitespace, broken indentation, etc)

 - Building with sparse (C=2) shows a lot of warnings, and adding endian
   checking (CF=-D__CHECK_ENDIAN__) is even worse.  Would be nice to get
   that fixed up too.

 - R.