[ewg] Re: status of ofed ipoib changes which are not upstream

[Eli Cohen]

On Sun, 2008-04-27 at 15:32 -0700, Roland Dreier wrote:
> > what about this patch:
>  > http://lists.openfabrics.org/pipermail/general/2008-March/048322.html
> 
> Looks mostly OK, I plan to merge it.
> 
> ...looking closer, what happens if the send queue has less than 16
> entries?  (set with send_queue_size on module load)
I assumed that no one will want to use such a low number but surely
someone will do it ;-) How about using a set function for the module
parameter and allowing values >= 2 * MAX_SEND_CQE?

> 
> Also maybe I'm missing it but where do you wait for all sends to
> complete and free pending skbs on module unload?

Through:
ipoib_ib_dev_stop => ipoib_drain_cq => while(poll_tx(priv));