[ewg] Re: [PATCH]

[Doron Shoham]

Vladimir Sokolovsky wrote:
> Should it be installed on SLES10/RHEL5 only?

Yes, including their updates (RH5.1, RH5.2, SLES10 sp1 and SLES10 sp2).

> 
> Another question: why do you need 'stgt' package in the install.pl?
> Currently,
> it can't be selected because it is not in the list of @user_packages and
> if it was
> added to the ofed.conf then it will add 'tgt-generic' to the list of
> selected packages
> instead...

The reason for using 'stgt' package was similar to the idea in iscsi.
SUSE named stgt as tgt and redhat named it scsi-target-utils.
My idea was that users will be able to add stgt in the conf
file with a generic name such as 'stgt'.
That why I think it would be better to put 'stgt' in the @user_packages (instead of 'tgt').

> 
> Please check the following patch that fixes issues above:
> 
> Disable 'tgt-generic' on ppc64 and ia64 platforms.

Looks great, thanks.
Just tell me what you think about the 'stgt' package.

Doron