[ewg] Re: [PATCH install.pl] tgt

[Vladimir Sokolovsky]

On Tue, 2008-08-26 at 11:46 +0300, Doron Shoham wrote:
> Vladimir Sokolovsky wrote:
> > On Tue, 2008-08-26 at 10:45 +0300, Doron Shoham wrote:
> >> Vladimir Sokolovsky wrote:
> >>> Should it be installed on SLES10/RHEL5 only?
> >> Yes, including their updates (RH5.1, RH5.2, SLES10 sp1 and SLES10 sp2).
> >>
> >>> Another question: why do you need 'stgt' package in the install.pl?
> >>> Currently,
> >>> it can't be selected because it is not in the list of @user_packages and
> >>> if it was
> >>> added to the ofed.conf then it will add 'tgt-generic' to the list of
> >>> selected packages
> >>> instead...
> >> The reason for using 'stgt' package was similar to the idea in iscsi.
> >> SUSE named stgt as tgt and redhat named it scsi-target-utils.
> >> My idea was that users will be able to add stgt in the conf
> >> file with a generic name such as 'stgt'.
> >> That why I think it would be better to put 'stgt' in the @user_packages (instead of 'tgt').
> >>
> > 
> > I see that 'tgt-generic' do that job.
> > 
> > 1240         'tgt-generic' =>
> > 1241             { name => ($distro eq 'SuSE') ? 'tgt': 'scsi-target-utils', parent => "tgt-generic",
> > 1242             selected => 0, installed => 0, rpm_exist => 0, rpm_exist32 => 0,
> > 
> > So, stgt can be removed and only 'tgt-generic' should be in the list of @user_packages.
> ok.
> just to make sure, now it stgt will be installed with tgt-generic=y in conf file?
> is there a way to change it to stgt=y?

Probably I missed something.
Please correct me if I am wrong:

1. There is one 'tgt-generic' source RPM.
2. After 'rpmbuild --rebuild ... tgt-generic.src.rpm' two binary RPMs
being created: 'tgt' and 'scsi-target-utils' on both SuSE and RedHat.
3. On SuSE you want to install the 'tgt' RPM.
   On RedHat - 'scsi-target-utils' RPM.

So, where stgt comes from?

Now, if tgt-generic=y in conf file then 'tgt' RPM will be installed on
SuSE and 'scsi-target-utils' will be installed on RedHat.

- Vladimir