[ewg] Re: [PATCH] IPoIB: fix race when manipulating mcast SKBs queue

[Roland Dreier]

 > ipoib_mcast_free() dequeues SKBs pending on the pkt_queue but needs to do that
 > with netif_tx_lock_bh() acquired.

I don't see why this would be required.  When ipoib_mcast_free() runs,
the mcast structure has been removed from all lists and I don't see how
any other context could simultaneously be adding packets to pkt_queue.
What is the race that you think this fixes?

 - R.