[ewg] Re: [PATCH] call skb_orphan() after sending an SKB

[Eli Cohen]

On Wed, 2008-02-06 at 15:11 +0200, Or Gerlitz wrote:
> Eli Cohen wrote:
> > On Wed, 2008-02-06 at 10:17 +0200, Or Gerlitz wrote:
> 
> > The problem with ttcpv was that it stopped sending packets since it was
> > waiting for freeing the memory. The system did not hang, just the
> > application (ttcpv) stopped sending. Other applications could continue
> > working over the ipoib interface.
> 
> What's ttcpv, doing web-search I only find ttcp, so I would be happy to 
> get pointer plus what param you were using to see the problem.
It's a variant of ttcp we're using here in our regression. Dotan can you
send a pointer?
> 
> >> Also, I see that you have added a call to netif_stop_queue(), is this to
> >> solve another problem?
> 
> > This was just a whole that I found in code review - when I post a zero
> > length packet, I still want this to affect the net queue control.
> 
> Why posting a zero len packet is related to the net queue control logic? 
> I was thinking it has to do with releasing "unsignaled SKBs"

Yes but if I have no more room in the tx ring I would like to stop the
queue even here.
> 
> Or
>