[ewg] Re: with the ipoib patches, debug prints spam the system log

[Or Gerlitz]

On 2/6/08, Eli Cohen <eli at mellanox.co.il> wrote:
> They are only visible when activating ipoib debug. I know it fills the
> dmesg ring with messages. Do you think I should remove them?

Yes, you should remove them.

The ipoib debug prints are very usefull to debug and analyze at the
field, however, your 3 prints per second addition makes them useless,
at least for me, and I use them a lot where working to debug and help
others, so please do.

Or


>
> On Wed, 2008-02-06 at 10:38 +0200, Or Gerlitz wrote:
> > Eli,
> >
> > You have left somehow too many... debug prints in the last patches,
> > please clean this up. See for example how the system log after less
> > then a minute when ipoib debug prints are opened, it has one original
> > print ("ib0: Send unicast ARP to 0023") and all the rest are yours.
> >
> > Or
> >
> > Feb  6 14:39:23  kernel: ib0: posting zlen send, wrid = 4: head = 2756, tail = 2752
> > Feb  6 14:39:23  kernel: ib0: ipoib_ib_tx_timer_func-427: head = 2757
> > Feb  6 14:39:25  kernel: ib0: posting zlen send, wrid = 39: head = 2919, tail = 2912
> > Feb  6 14:39:25  kernel: ib0: ipoib_ib_tx_timer_func-427: head = 2920
> > Feb  6 14:39:25  kernel: ib0: posting zlen send, wrid = 15: head = 2959, tail = 2944
> > Feb  6 14:39:25  kernel: ib0: ipoib_ib_tx_timer_func-427: head = 2960
> > Feb  6 14:39:27  kernel: ib0: posting zlen send, wrid = 8: head = 3080, tail = 3072
> > Feb  6 14:39:27  kernel: ib0: ipoib_ib_tx_timer_func-427: head = 3081
> > Feb  6 14:39:34  kernel: ib0: posting zlen send, wrid = 51: head = 3699, tail = 3696
> > Feb  6 14:39:34  kernel: ib0: ipoib_ib_tx_timer_func-427: head = 3700
> > Feb  6 14:39:35  kernel: ib0: posting zlen send, wrid = 25: head = 3737, tail = 3728
> > Feb  6 14:39:35  kernel: ib0: ipoib_ib_tx_timer_func-427: head = 3738
> > Feb  6 14:39:35  kernel: ib0: posting zlen send, wrid = 3: head = 3779, tail = 3776
> > Feb  6 14:39:35  kernel: ib0: ipoib_ib_tx_timer_func-427: head = 3780
> > Feb  6 14:39:36  kernel: ib0: posting zlen send, wrid = 48: head = 3824, tail = 3808
> > Feb  6 14:39:36  kernel: ib0: ipoib_ib_tx_timer_func-427: head = 3825
> > Feb  6 14:39:38  kernel: ib0: posting zlen send, wrid = 24: head = 3992, tail = 3984
> > Feb  6 14:39:38  kernel: ib0: ipoib_ib_tx_timer_func-427: head = 3993
> > Feb  6 14:39:38  kernel: ib0: posting zlen send, wrid = 4: head = 4036, tail = 4032
> > Feb  6 14:39:38  kernel: ib0: ipoib_ib_tx_timer_func-427: head = 4037
> > Feb  6 14:39:46  kernel: ib0: Send unicast ARP to 0023
> > Feb  6 14:39:46  kernel: ib0: posting zlen send, wrid = 11: head = 4683, tail = 4672
> > Feb  6 14:39:46  kernel: ib0: ipoib_ib_tx_timer_func-427: head = 4684
> > Feb  6 14:39:58  kernel: ib0: posting zlen send, wrid = 58: head = 5626, tail = 5616
> > Feb  6 14:39:58  kernel: ib0: ipoib_ib_tx_timer_func-427: head = 5627
> > Feb  6 14:39:59  kernel: ib0: posting zlen send, wrid = 56: head = 5752, tail = 5744
> > Feb  6 14:39:59  kernel: ib0: ipoib_ib_tx_timer_func-427: head = 5753
> > Feb  6 14:40:01  kernel: ib0: posting zlen send, wrid = 54: head = 5878, tail = 5872
> > Feb  6 14:40:01  kernel: ib0: ipoib_ib_tx_timer_func-427: head = 5879
> > Feb  6 14:40:01  kernel: ib0: posting zlen send, wrid = 30: head = 5918, tail = 5904
> > Feb  6 14:40:01  kernel: ib0: ipoib_ib_tx_timer_func-427: head = 5919
> > Feb  6 14:40:10  kernel: ib0: posting zlen send, wrid = 33: head = 6689, tail = 6672
> > Feb  6 14:40:10  kernel: ib0: ipoib_ib_tx_timer_func-427: head = 6690
> > Feb  6 14:40:13  kernel: ib0: posting zlen send, wrid = 48: head = 6896, tail = 6880
> > Feb  6 14:40:13  kernel: ib0: ipoib_ib_tx_timer_func-427: head = 6897
> > Feb  6 14:40:13  kernel: ib0: posting zlen send, wrid = 26: head = 6938, tail = 6928
> > Feb  6 14:40:13  kernel: ib0: ipoib_ib_tx_timer_func-427: head = 6939
> > Feb  6 14:40:15  kernel: ib0: posting zlen send, wrid = 61: head = 7101, tail = 7088
> > Feb  6 14:40:15  kernel: ib0: ipoib_ib_tx_timer_func-427: head = 7102
>
> _______________________________________________
> ewg mailing list
> ewg at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
>