[ewg][PATCH][1/2] SRP multipath failover within 60 seconds,

Vu Pham vuhuong at mellanox.com
Wed Feb 6 10:00:01 PST 2008


Roland Dreier wrote:
>  > diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
>  > index 950228f..45a2533 100644
>  > --- a/drivers/infiniband/ulp/srp/ib_srp.c
>  > +++ b/drivers/infiniband/ulp/srp/ib_srp.c
>  > @@ -400,7 +400,6 @@
>  >  		printk(KERN_DEBUG PFX "Sending CM DREQ failed\n");
>  >  		return;
>  >  	}
>  > -	wait_for_completion(&target->done);
>  >  }
>  >  
>  >  static void srp_remove_work(struct work_struct *work)
>  > @@ -1266,7 +1294,6 @@
>  >  	case IB_CM_TIMEWAIT_EXIT:
>  >  		printk(KERN_ERR PFX "connection closed\n");
>  >  
>  > -		comp = 1;
>  >  		target->status = 0;
>  >  		break;
> 
> Seems like this would leak the cm_id?

I said in my [0/2] email, this patch should be applied on 
top of srp_1_recreate_at_reconnect.patch which is already in 
ofed_1_3.git tree kernel_patches/fixes/ directory

I attached it here


-------------- next part --------------
A non-text attachment was scrubbed...
Name: srp_1_recreate_at_reconnect.patch
Type: text/x-diff
Size: 2640 bytes
Desc: not available
URL: <http://lists.openfabrics.org/pipermail/ewg/attachments/20080206/48ae5b21/attachment.patch>


More information about the ewg mailing list