[ewg] Re: [PATCH] IB/ipoib - Problem with latest OFED 1.3 build... IPoIB and iPATH

[Shirley Ma]

Hello Ralph,

      I looked at ehca and mthca, in create_ah(), both driver didn't check
dlid condition check like ipath here. In the port initilizaiton,
priv->local_lid is set to 0 which is created by ipoib_0190_unsig_udqp.patch
in RC4. I will let Eli look at this problem.

static struct ib_ah *ipath_create_ah(struct ib_pd *pd,
                                     struct ib_ah_attr *ah_attr)
{
        struct ipath_ah *ah;
        struct ib_ah *ret;
        struct ipath_ibdev *dev = to_idev(pd->device);
        unsigned long flags;

        /* A multicast address requires a GRH (see ch. 8.4.1). */
        if (ah_attr->dlid >= IPATH_MULTICAST_LID_BASE &&
            ah_attr->dlid != IPATH_PERMISSIVE_LID &&
            !(ah_attr->ah_flags & IB_AH_GRH)) {
                ret = ERR_PTR(-EINVAL);
                goto bail;
        }

        if (ah_attr->dlid == 0) {
                ret = ERR_PTR(-EINVAL);
                goto bail;
        }


Thanks
Shirley
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ewg/attachments/20080208/d85dcab9/attachment.html>