[ewg] Re: [ofa-general] IB/ipoib: ipoib_ib_post_receive: infinite loop in error path

[Or Gerlitz]

Hoang-Nam Nguyen wrote:
> Hello Eli!
> Looked at ipoib code from ofed-1.3-rc4 and the saw the following code snippet
> in ipoib_ib_post_receive():

Hi Nam,

Again,

Can you exclude the general list from such postings? in this example you 
are treating below patches which are not candidates for upstream 
inclusion but rather

last-minute-insertions-to-ofed-using-the-experimental-natute-of-it

etc, so creating confusion, thanks

Or.

> 
> 	if (++priv->rx_outst == UD_POST_RCV_COUNT) {
> 		ret = ib_post_recv(priv->qp, priv->rx_wr_draft, &bad_wr);
> 
> 		if (unlikely(ret)) {
> 			ipoib_warn(priv, "receive failed for buf %d (%d)\n", id, ret);
> 			while (bad_wr) {
> 				id = bad_wr->wr_id & ~IPOIB_OP_RECV;
> 				ipoib_sg_dma_unmap_rx(priv,
> 						      priv->rx_ring[i].mapping);
> #1/ipoib_0240_4kmtu.patch: should be priv->rx_ring[id].mapping
> 				dev_kfree_skb_any(priv->rx_ring[id].skb);
> 				priv->rx_ring[id].skb = NULL;
> #2/ipoib_0220_ud_post_list.patch: missing iterator forwarding, ie bad_wr = bad_wr->next;
> 			}
> 
> 		}
> 		priv->rx_outst = 0;
> 	}
> 
> #1: I've talked with Shirley about this.
> #2: I thought to have seen you fixed it, but still see it in rc4 after called
> configure script.
> 
> Nam
> 
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
> 
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general