[ewg] Re: [PATCH] Set the dependencies of openibd and iscsi services

[Doron Shoham]

Vladimir Sokolovsky wrote:
> Doron Shoham wrote:
>>  iscsi service should start after openibd service.
>>  iscsi service should stop before openibd service.
>>
>> Signed-off-by: Doron Shoham <dorons at voltaire.com>
>> ---
> 
> Hi Doron,
> Why can't you just put in the /etc/init.d/iscsi:
> 
> # chkconfig: 2345 16 84

Why is openibd's start 15 and stop 85?
will it always be correct?

> 
> And in the /etc/init.d/open-iscsi:
> Required-Start: openibd
> 
> And then update ofa_kernel.spec to set
> Required-Stop: open-iscsi
> In case that iser was selected and OS is SuSE.

You are right.
I'll do it that way.

> 
> This will change about 5 lines of code instead of about 150 lines of
> your patch.
> 
> Regards,
> Vladimir

I'll make a new patch.

Thanks,
Doron