[ewg] [PATCH] IB/iser: Add iSER fix that will be merged into 2.6.25

Erez Zilber erezz at voltaire.com
Sun Jan 20 23:30:05 PST 2008


This fix adds a printk before initiating a BUG() when
receiving an unhandled RDMA-CM event.

Signed-off-by: Erez Zilber <erezz at voltaire.com>
---
 ...nformation_about_unhandled_RDMA_CM_events.patch |   33 ++++++++++++++++++++
 1 files changed, 33 insertions(+), 0 deletions(-)
 create mode 100644 kernel_patches/fixes/iser_01_Print_information_about_unhandled_RDMA_CM_events.patch

diff --git a/kernel_patches/fixes/iser_01_Print_information_about_unhandled_RDMA_CM_events.patch b/kernel_patches/fixes/iser_01_Print_information_about_unhandled_RDMA_CM_events.patch
new file mode 100644
index 0000000..4b96c8f
--- /dev/null
+++ b/kernel_patches/fixes/iser_01_Print_information_about_unhandled_RDMA_CM_events.patch
@@ -0,0 +1,33 @@
+Print information about unhandled RDMA CM events
+
+Some RDMA CM events are not supported or not handled in iSER.
+This patch adds some info (printk) for the user about them.
+
+Signed-off-by: Erez Zilber <erezz at voltaire.com>
+---
+ drivers/infiniband/ulp/iser/iser_verbs.c |    6 ++----
+ 1 files changed, 2 insertions(+), 4 deletions(-)
+
+diff --git a/drivers/infiniband/ulp/iser/iser_verbs.c b/drivers/infiniband/ulp/iser/iser_verbs.c
+index 654a4dc..675d00b 100644
+--- a/drivers/infiniband/ulp/iser/iser_verbs.c
++++ b/drivers/infiniband/ulp/iser/iser_verbs.c
+@@ -475,13 +475,11 @@ static int iser_cma_handler(struct rdma_cm_id *cma_id, struct rdma_cm_event *eve
+ 		iser_disconnected_handler(cma_id);
+ 		break;
+ 	case RDMA_CM_EVENT_DEVICE_REMOVAL:
++		iser_err("Device removal is currently unsupported\n");
+ 		BUG();
+ 		break;
+-	case RDMA_CM_EVENT_CONNECT_RESPONSE:
+-		BUG();
+-		break;
+-	case RDMA_CM_EVENT_CONNECT_REQUEST:
+ 	default:
++		iser_err("Unexpected RDMA CM event (%d)\n", event->event);
+ 		break;
+ 	}
+ 	return ret;
+-- 
+1.5.3.7
+
-- 
1.5.3.7





More information about the ewg mailing list