[ewg] Re: Distributing the SRP target source code

[Bart Van Assche]

On Jan 29, 2008 11:09 AM, Vu Pham <vuhuong at mellanox.com> wrote:
> Bart Van Assche wrote:
> > Please remove drivers/infiniband/ulp/srpt/scsi_tgt.h and scst_const.h
> > from the OFED distribution. It's better that the SRP target doesn't
> > build if SCST was not yet installed instead of having to experience a
> > kernel crash when OFED was built before SCST.
>
> It's clear from both ofed/srpt readme and Vlad's SCST bit
> fat warning. You either build scst before ofed or
> rebuild ofed

After having installed SCST and OFED 1.3 on a system there will be two
incompatible versions present on that system of SCST's header file
scsi_tgt.h. This is confusing and questionable.

Furthermore, the SRP target will only build correctly if
/usr/local/include is in the include path before . (current
directory). Relying on the order of directories in the include path is
a very questionable practice too.

Bart.