[ewg] Re: [Scst-devel] [ofa-general] OFED 1.3 RC2 release is available

[Vu Pham]

Bart Van Assche wrote:
> On Jan 28, 2008 12:47 PM, Vladislav Bolkhovitin <vst at vlnb.net> wrote:
>> Bart Van Assche wrote:
>>> Apparently OFED 1.3 includes SRP target support ? Although I consider
>>> SRP target support as a very valuable contribution, it should not be
>>> included in the OFED distribution but in the SCST distribution. The
>>> reason is that the SRP target relies on SCST interfaces that can
>>> potentially change with each new SCST release. Consider e.g. the
>>> scsi_tgt.h header file, which defines  the interface between SCST core
>>> and SCST mid-level modules. The version of this file included with
>>> git://git.openfabrics.org/~vu/ofed_1_3.git (0.9.6-pre3) is
>>> incompatible with the latest scsi_tgt.h file from the SCST project
>>> (0.9.6-rc1). This may cause kernel crashes for OFED 1.3 SRP target
>>> users who combine OFED 1.3 with the latest SCST version.
>> No it won't crash, it will refuse to run. I've recently added in SCST
>> protection against attempts running mixed SCST and target driver versions.
>>
>> BTW, there is a
>>
>> ****************************************************************
>> *!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!*
>> *!!                                                          !!*
>> *!! BIG FAT WARNING ABOUT MIXED VERSIONS PROBLEM             !!*
>> *!!                                                          !!*
>> *!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!*
>> ****************************************************************
> 
> Hello Vladislav,
> 
> I did not test the above scenario -- what I wrote was the result of
> source reading. It is very good that interface versions are checked
> inside SCST before mid-level drivers are used. Even with interface
> version checking in place, my opinion is that the SRP target code
> should be included in the SCST project and not in the OFED project.
> 
> Bart.

Hi Bart,

On srpt readme file, the prerequisite is install SCST BEFORE 
ofed-1.3 or like Vlad warning "recompiling ofed" if you 
install scst after install ofed.

here is one of the reason srpt is part of ofed not scst:

SCST is GPL
ofed + srpt is GPL or BSD


-vu