[ewg] [PATCH] IB/core: remove an always true condition
Eli Cohen
eli at dev.mellanox.co.il
Mon Jul 14 00:22:01 PDT 2008
command is an unsigned variable so it can't be negative.
Signed-off-by: Eli Cohen <eli at mellanox.co.il>
---
drivers/infiniband/core/uverbs_main.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/core/uverbs_main.c b/drivers/infiniband/core/uverbs_main.c
index 965c4be..00b7574 100644
--- a/drivers/infiniband/core/uverbs_main.c
+++ b/drivers/infiniband/core/uverbs_main.c
@@ -584,8 +584,7 @@ static ssize_t ib_uverbs_write(struct file *filp, const char __user *buf,
if (hdr.in_words * 4 != count)
return -EINVAL;
- if (hdr.command < 0 ||
- hdr.command >= ARRAY_SIZE(uverbs_cmd_table) ||
+ if (hdr.command >= ARRAY_SIZE(uverbs_cmd_table) ||
!uverbs_cmd_table[hdr.command] ||
!(file->device->ib_dev->uverbs_cmd_mask & (1ull << hdr.command)))
return -EINVAL;
--
1.5.6
More information about the ewg
mailing list