[ewg] Re: Please pull: PAT patch fix

[Vladimir Sokolovsky]

On Sat, 2008-11-01 at 23:54 -0700, Yannick Cote wrote:
> Hi Vlad,
> 
> this patch reverts and correctly reinstate the previous IB/ipath PAT patch.
> 
> tree: ssh://openfabrics.org/home/ycote/scm/ofed_1_4/linux-2.6.git
> branch: ofed_kernel
> 
> commit 2d7ffce69f717aa21a6748b52c718d7f65956d49
> Author: Yannick Cote <yannick.cote at qlogic.com>
> Date:   Fri Oct 31 21:55:45 2008 -0700
> 
>     IB/ipath: Fix the PAT patch and backports
>    
>     Provide write-combining mappings via PAT
>    
>     Signed-off-by: Yannick Cote <yannick.cote at qlogic.com>
> 
> Regards,
> 
>  - Yan

Hi Yan,
The commit above cause compilation failure on kernels 2.6.25 and 2.6.27,
see below. So, I reverted both commits.
Please make sure compilation passed on all supported kernels.

See, HOWTO check (cross build) OFED kernel build from your git tree on 
openfabrics.org server: https://wiki.openfabrics.org/tiki-index.php?page=HOWTO+Build+OFA+kernel+package

2.6.25:
  gcc -Wp,-MD,/tmp/ofa_1_4_dev_kernel-20081102-1526_linux-2.6.25_check/drivers/infiniband/hw/ipath/.ipath_wc_pat.o.d  -nostdinc -isystem /usr/lib/gcc/x86_64-redhat-linux/4.1.1/include -D__KERNEL__ -include include/linux/autoconf.h  -include /tmp/ofa_1_4_dev_kernel-20081102-1526_linux-2.6.25_check/include/linux/autoconf.h  -I/tmp/ofa_1_4_dev_kernel-20081102-1526_linux-2.6.25_check/kernel_addons/backport/2.6.25/include/   -Werror-implicit-function-declaration  -I/tmp/ofa_1_4_dev_kernel-20081102-1526_linux-2.6.25_check/include  -I/tmp/ofa_1_4_dev_kernel-20081102-1526_linux-2.6.25_check/drivers/infiniband/debug  -I/usr/local/include/scst  -I/tmp/ofa_1_4_dev_kernel-20081102-1526_linux-2.6.25_check/drivers/infiniband/ulp/srpt  -I/tmp/ofa_1_4_dev_kernel-20081102-1526_linux-2.6.25_check/drivers/net/cxgb3  -Iinclude    -I/.autodirect/mswg2/work/kernel.org/x86_64/linux-2.6.25/arch/x86_64/include   -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -Werror
 -implicit-function-declaration -Os  -fno-stack-protector -m64 -mtune=generic -mno-red-zone -mcmodel=kernel -funit-at-a-time -maccumulate-outgoing-args  -DCONFIG_AS_CFI=1 -DCONFIG_AS_CFI_SIGNAL_FRAME=1 -pipe -Wno-sign-compare -fno-asynchronous-unwind-tables -mno-sse -mno-mmx -mno-sse2 -mno-3dnow  -fomit-frame-pointer -g -Wdeclaration-after-statement -Wno-pointer-sign   -DIPATH_IDSTR='"QLogic kernel.org driver"' -DIPATH_KERN_TYPE=0  -DMODULE -D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(ipath_wc_pat)"  -D"KBUILD_MODNAME=KBUILD_STR(ib_ipath)" -c -o /tmp/ofa_1_4_dev_kernel-20081102-1526_linux-2.6.25_check/drivers/infiniband/hw/ipath/ipath_wc_pat.o /tmp/ofa_1_4_dev_kernel-20081102-1526_linux-2.6.25_check/drivers/infiniband/hw/ipath/ipath_wc_pat.c
/tmp/ofa_1_4_dev_kernel-20081102-1526_linux-2.6.25_check/drivers/infiniband/hw/ipath/ipath_wc_pat.c: In function 'ioremap_wc':
/tmp/ofa_1_4_dev_kernel-20081102-1526_linux-2.6.25_check/drivers/infiniband/hw/ipath/ipath_wc_pat.c:262: error: implicit declaration of function '__ioremap'
/tmp/ofa_1_4_dev_kernel-20081102-1526_linux-2.6.25_check/drivers/infiniband/hw/ipath/ipath_wc_pat.c:262: warning: return makes pointer from integer without a cast
make[4]: *** [/tmp/ofa_1_4_dev_kernel-20081102-1526_linux-2.6.25_check/drivers/infiniband/hw/ipath/ipath_wc_pat.o] Error 1

2.6.27:
  gcc -Wp,-MD,/tmp/ofa_1_4_dev_kernel-20081102-1526_linux-2.6.27_check/drivers/infiniband/hw/ipath/.ipath_wc_pat.o.d  -nostdinc -isystem /usr/lib/gcc/x86_64-redhat-linux/4.1.1/include -D__KERNEL__ -include include/linux/autoconf.h  -include /tmp/ofa_1_4_dev_kernel-20081102-1526_linux-2.6.27_check/include/linux/autoconf.h    -Werror-implicit-function-declaration  -I/tmp/ofa_1_4_dev_kernel-20081102-1526_linux-2.6.27_check/include  -I/tmp/ofa_1_4_dev_kernel-20081102-1526_linux-2.6.27_check/drivers/infiniband/debug  -I/usr/local/include/scst  -I/tmp/ofa_1_4_dev_kernel-20081102-1526_linux-2.6.27_check/drivers/infiniband/ulp/srpt  -I/tmp/ofa_1_4_dev_kernel-20081102-1526_linux-2.6.27_check/drivers/net/cxgb3  -Iinclude    -I/.autodirect/mswg2/work/kernel.org/x86_64/linux-2.6.27/arch/x86_64/include   -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -Werror-implicit-function-declaration -Os -m64 -mtune=generic -mno-red-zone -mcmodel=kernel -funit-at-a-t
 ime -maccumulate-outgoing-args -DCONFIG_AS_CFI=1 -DCONFIG_AS_CFI_SIGNAL_FRAME=1 -pipe -Wno-sign-compare -fno-asynchronous-unwind-tables -mno-sse -mno-mmx -mno-sse2 -mno-3dnow -Iinclude/asm-x86/mach-default -fno-stack-protector -fno-omit-frame-pointer -fno-optimize-sibling-calls -g -Wdeclaration-after-statement -Wno-pointer-sign -DIPATH_IDSTR='"QLogic kernel.org driver"' -DIPATH_KERN_TYPE=0 -DMODULE -D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(ipath_wc_pat)"  -D"KBUILD_MODNAME=KBUILD_STR(ib_ipath)" -c -o /tmp/ofa_1_4_dev_kernel-20081102-1526_linux-2.6.27_check/drivers/infiniband/hw/ipath/ipath_wc_pat.o /tmp/ofa_1_4_dev_kernel-20081102-1526_linux-2.6.27_check/drivers/infiniband/hw/ipath/ipath_wc_pat.c
/tmp/ofa_1_4_dev_kernel-20081102-1526_linux-2.6.27_check/drivers/infiniband/hw/ipath/ipath_wc_pat.c: In function 'read_and_modify_pat':
/tmp/ofa_1_4_dev_kernel-20081102-1526_linux-2.6.27_check/drivers/infiniband/hw/ipath/ipath_wc_pat.c:185: error: too many arguments to function 'smp_call_function'
/tmp/ofa_1_4_dev_kernel-20081102-1526_linux-2.6.27_check/drivers/infiniband/hw/ipath/ipath_wc_pat.c:196: error: too many arguments to function 'smp_call_function'
/tmp/ofa_1_4_dev_kernel-20081102-1526_linux-2.6.27_check/drivers/infiniband/hw/ipath/ipath_wc_pat.c: In function 'restore_pat':
/tmp/ofa_1_4_dev_kernel-20081102-1526_linux-2.6.27_check/drivers/infiniband/hw/ipath/ipath_wc_pat.c:210: error: too many arguments to function 'smp_call_function'
make[4]: *** [/tmp/ofa_1_4_dev_kernel-20081102-1526_linux-2.6.27_check/drivers/infiniband/hw/ipath/ipath_wc_pat.o] Error 1

Regards,
Vladimir