[ewg] Re: Continue of "defer skb_orphan() until irqs enabled"

[Olga Shern (Voltaire)]

We run regression tests and it were OK.
We will continue the testing and update if we see any issues.

Olga

On Sun, Sep 28, 2008 at 2:40 PM, Olga Shern (Voltaire)
<olga.shern at gmail.com> wrote:
> Hi Eli,
>
> We also want to run regression tests with this patch.
> Please let me know when OFED daily build will include it.
>
> Thanks
> Olga
>
> On Sun, Sep 28, 2008 at 2:39 PM, Eli Cohen <eli at dev.mellanox.co.il> wrote:
>> On Fri, Sep 26, 2008 at 01:19:00PM -0700, Roland Dreier wrote:
>>> How about this?  Instead of trying to rely on some complicated and
>>> fragile reasoning about when some race might occur, let's just do what
>>> we want to do anyway and get rid of LLTX.  We change from priv->tx_lock
>>> (taken with IRQ disabling) to netif_tx_lock (taken on with
>>> BH-disabling).  And then we can keep the skb_orphan in the place it is,
>>> since our xmit routine runs with IRQs enabled.
>>>
>>
>> We'll integrate this into ofed 1.4 and monitor this through our
>> regression system.
>> _______________________________________________
>> ewg mailing list
>> ewg at lists.openfabrics.org
>> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
>>
>