[ewg] Re: Continue of "defer skb_orphan() until irqs enabled"

[akepner at sgi.com]

On Fri, Sep 26, 2008 at 01:19:00PM -0700, Roland Dreier wrote:
> How about this?  Instead of trying to rely on some complicated and
> fragile reasoning about when some race might occur, let's just do what
> we want to do anyway and get rid of LLTX.  We change from priv->tx_lock
> (taken with IRQ disabling) to netif_tx_lock (taken on with
> BH-disabling).  And then we can keep the skb_orphan in the place it is,
> since our xmit routine runs with IRQs enabled.
> ...

Thanks for doing this work, Roland.

We'll give it a test asap. (Actually, we'll need to port the patch 
to OFED 1.3.1 first, since that's what we're using/shipping.)

-- 
Arthur