[ewg] Re: [PATCH v3] mlx4_ib: Optimize hugetlab pages support

[Yossi Etigin]

Hi Eli,

I've placed a printk in the new hugetlb function to print n and j.
While running the mckey test (attached in bugzilla), I got j=0, n=1.

Why do you say that the number of pages must cover HUGE_PAGES?
In ib_umem_get, hugetlb is set to 0 only if any of the pages is 
not-hugetlb - otherwise it's 1. Am I missing something?

--Yossi

On Thu, 2 Apr 2009, Eli Cohen wrote:

> On Mon, Mar 30, 2009 at 06:49:37PM +0300, Yossi Etigin wrote:
>
> Yossi,
>
> I wouldn't expect this to matter since handle_hugetlb_user_mr() only
> gets called when the memory is huge pages which means the number of
> PAGE_SIZE pages cover full HUGE_PAGES.  You mention in Bugzilla an
> "mckey" test but I don't know this test. Can you send how to obatain
> the test and instructions how to build it and run it?
>
>> +
>> +	if (cur_size) {
>> +		arr[j++] = cur_addr;
>> +	}
>> +
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
>