[ewg] Re: [PATCH] IB/qib: fix IPoIB device stop deadlock

Vladimir Sokolovsky vlad at dev.mellanox.co.il
Wed Dec 9 00:38:34 PST 2009


Ralph Campbell wrote:
> Vlad, please pull 4 more fixes to the qib driver from:
> 
> git://git.openfabrics.org/~ralphc/linux-2.6/.git ofed_kernel_1_5
> 
> commit 70f277ec61809c15b3352aa6b650882ebef05235
> Author: Ralph Campbell (QLogic) <ralphc at hosting.openfabrics.org>
> Date:   Tue Dec 8 17:14:43 2009 -0800
> 
>     IB/qib: fix IPoIB device stop deadlock
>     
>     We create our own workqueue mainly because we want to be
>     able to flush it when devices are being removed.  We can't
>     use schedule_work()/flush_scheduled_work() because both
>     unregister_netdev() and linkwatch_event take the rtnl lock,
>     so flush_scheduled_work() can deadlock during device removal.
>     
>     Signed-off-by: Mitko Haralanov <mitko at qlogic.com>
> 
> commit 9e829f8742501afefc49c1b16945322cd6577dfd
> Author: Ralph Campbell (QLogic) <ralphc at hosting.openfabrics.org>
> Date:   Tue Dec 8 17:12:02 2009 -0800
> 
>     IB/qib: serdes changes for QME7342 serdes
>     
>     Because we now have different values of H1 all over, I redid the h1_vals
>     code that we weren't really using, changed it to a single h1_val,
>     and initialized for the board types that need different values.
>     
>     Signed-off-by: Dave Olson <dave.olson at qlogic.com>
> 
> commit 52cb89d80698f6cfdf7d58f0b0bbef85cd70dc69
> Author: Ralph Campbell (QLogic) <ralphc at hosting.openfabrics.org>
> Date:   Tue Dec 8 17:11:22 2009 -0800
> 
>     IB/qib: added missing code to report if 7322 memory BIST failed
>     
>     Don't clear the memory built-in-self-test error bit so it gets reported.
>     
>     Signed-off-by: Dave Olson <dave.olson at qlogic.com>
> 
> commit 56d291199ea1479a441af974ab3f311b4703c897
> Author: Ralph Campbell (QLogic) <ralphc at hosting.openfabrics.org>
> Date:   Tue Dec 8 17:10:35 2009 -0800
> 
>     IB/qib: improve twsi error messages for human beings
>     
>     Some people were confused by TWSI, so make messages somewhat clearer.
>     
>     Signed-off-by: Dave Olson <dave.olson at qlogic.com>
> 
> 
> 
> 

Done,

Regards,
Vladimir



More information about the ewg mailing list