[ewg] [PATCH] ib_mad: Fix RMPP header RRespTime manipulation

Ramachandra K ramachandra.kuchimanchi at qlogic.com
Thu Feb 26 08:38:38 PST 2009


Fix ib_set_rmpp_flags() to use the correct bit mask for RRespTime.
In the 8-bit field of the RMPP header, the first 5 bits
are RRespTime and next 3 bits are RMPPFlags. Hence to retain
the first 5 bits, the mask should be 0xF8 instead of 0xF1.

Signed-off-by: Ramachandra K <ramachandra.kuchimanchi at qlogic.com>
---

diff --git a/include/rdma/ib_mad.h b/include/rdma/ib_mad.h
index 5f6c40f..1a0f409 100644
--- a/include/rdma/ib_mad.h
+++ b/include/rdma/ib_mad.h
@@ -290,7 +290,7 @@ static inline void ib_set_rmpp_resptime(struct ib_rmpp_hdr *rmpp_hdr, u8 rtime)
  */
 static inline void ib_set_rmpp_flags(struct ib_rmpp_hdr *rmpp_hdr, u8 flags)
 {
-	rmpp_hdr->rmpp_rtime_flags = (rmpp_hdr->rmpp_rtime_flags & 0xF1) |
+	rmpp_hdr->rmpp_rtime_flags = (rmpp_hdr->rmpp_rtime_flags & 0xF8) |
 				     (flags & 0x7);
 }
 






More information about the ewg mailing list