[ewg] Re: [PATCH v1] mlx4_ib: Optimize hugetlab pages support

[Eli Cohen]

On Thu, Jan 22, 2009 at 09:07:41PM -0800, Roland Dreier wrote:
> 
> seems this might underestimate by 1 if the region doesn't start/end on a
> huge-page aligned boundary (but we would still want to use big pages to
> register it).
> 

Looks like we must pass the virtual address through struct ib_umem to
the low level driver.

> 
> I think we could avoid the uninitialized_var() stuff and having restart
> at all by just doing cur_size = 0 at the start of the loop, and then
> instead of if (restart) just test if cur_size is 0.
>

initializing cur_size and eliminating restart works fine but cur_addr
still needs this trick. 

I am sending two patches, one for ib_core and one for mlx4.