[ewg] Re: [PATCH v3] libibmad: Handle MAD redirection

[Jason Gunthorpe]

On Wed, Jul 01, 2009 at 09:59:41AM -0400, Hal Rosenstock wrote:

> > +static int redirect_port(ib_portid_t *port, uint8_t *mad)
> > +{
> > + ?? ?? ?? port->lid = mad_get_field(mad, 64, IB_CPI_REDIRECT_LID_F);
> > + ?? ?? ?? if (!port->lid) {
> > + ?? ?? ?? ?? ?? ?? ?? IBWARN("GID-based redirection is not supported");
> > + ?? ?? ?? ?? ?? ?? ?? return -1;
> > + ?? ?? ?? }
> 
> Sorry for the confusion: determination of GID redirection should be
> based on a comparison of the RedirectGID to 0. It's valid to supply
> both a non zero RedirectGID and RedirectLID.

?? The above is correct. As I said, RedirectGID is not allowed to be 0.

Jason