[ewg] Re: OFED 1.5 Problem on ia64 with your kernel_addons/backport/2.6.22/bitops.h

[Jon Mason]

I should have the backports for 2.6.25 and 2.6.22 done today.  I'll roll the fox for this into those changes.

Thanks,
Jon

On Thu, Jun 18, 2009 at 02:35:55PM +0300, Jack Morgenstein wrote:
> Jon,
> 
> The commit below added file kernel_addons/backport/2.6.22/bitops.h.
> On ia64, we get the following error in the OFED 1.5 build
> (from e-mail: [ofa-general] ofa_1_5_kernel 20090618-0200 daily build status):
> 
> Build failed on ia64 with linux-2.6.22
> Log:
>      from /home/vlad/tmp/ofa_1_5_kernel-20090618-0200_linux-2.6.22_ia64_check/drivers/infiniband/core/addr.c:36:
> /home/vlad/tmp/ofa_1_5_kernel-20090618-0200_linux-2.6.22_ia64_check/kernel_addons/backport/2.6.22/include/asm/bitops.h: In function 'clear_bit_unlock':
> /home/vlad/tmp/ofa_1_5_kernel-20090618-0200_linux-2.6.22_ia64_check/kernel_addons/backport/2.6.22/include/asm/bitops.h:8: error: implicit declaration of function 'smp_mb'
> make[4]: *** [/home/vlad/tmp/ofa_1_5_kernel-20090618-0200_linux-2.6.22_ia64_check/drivers/infiniband/core/addr.o] Error 1
> 
> Problem is here (see ***==>):
> #ifndef BACKPORT_ASM_BITOPS_H
> #define BACKPORT_ASM_BITOPS_H
> 
> #include_next <asm/bitops.h>
> 
> static inline void clear_bit_unlock(unsigned long nr, volatile unsigned long *addr)
> {
> ***==>  smp_mb__before_clear_bit();   <===**
>         clear_bit(nr, addr);
> }
> 
> #endif
> 
> 
> -Jack
> 
> ======================================================
> commit efd0ec53f7ee8104d6648b1df494af8413e7db55
> Author: Jon Mason <jon at opengridcomputing.com>
> Date:   Tue Jun 2 18:41:13 2009 -0500
> 
>     NFSRDMA: NFS backport for 2.6.22
> 
>     This patch provides the NFS backport for 2.6.22.  Since the RDMA
>     infrastructure does not work for this kernel release, only TCP
>     support has been tested.  It passes Connectathon as a client and server.
> 
>     Signed-Off-By: Jon Mason <jon at opengridcomputing.com>