[ewg] Re: [PATCH OFED-1.5] NFSRDMA: NFS backport for 2.6.22

[Jon Mason]

On Thu, Jun 25, 2009 at 10:43:02AM -0500, Jon Mason wrote:
> On Thu, Jun 25, 2009 at 04:23:13PM +0300, Jack Morgenstein wrote:
> > On Friday 19 June 2009 19:14, Jon Mason wrote:
> > > This patch provides the NFS backport for 2.6.22.
> > > 
> > > It passes Connectathon as a client and server over TCP and RDMA.
> > > 
> > > Signed-Off-By: Jon Mason <jon at opengridcomputing.com>
> > > 
> > This patch fails compilation on the 2.6.22 kernel, as follows:
> > jackm at mtldesk006:/local/of15/ofed_kernel-2.6.22> make -k all > /dev/null
> > /local/of15/ofed_kernel-2.6.22/fs/nfs/nfsroot.c:132: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘__initconst’
> > /local/of15/ofed_kernel-2.6.22/fs/nfs/nfsroot.c: In function ‘root_nfs_parse’:
> > /local/of15/ofed_kernel-2.6.22/fs/nfs/nfsroot.c:191: error: ‘tokens’ undeclared (first use in this function)
> > /local/of15/ofed_kernel-2.6.22/fs/nfs/nfsroot.c:191: error: (Each undeclared identifier is reported only once
> > /local/of15/ofed_kernel-2.6.22/fs/nfs/nfsroot.c:191: error: for each function it appears in.)
> > make[3]: *** [/local/of15/ofed_kernel-2.6.22/fs/nfs/nfsroot.o] Error 1
> > make[3]: Target `__build' not remade because of errors.
> > make[2]: *** [/local/of15/ofed_kernel-2.6.22/fs/nfs] Error 2
> > make[2]: Target `__build' not remade because of errors.
> > make[1]: *** [_module_/local/of15/ofed_kernel-2.6.22] Error 2
> > make[1]: Target `modules' not remade because of errors.
> > make: *** [kernel] Error 2
> > make: Target `all' not remade because of errors.
> > 
> > Note that in file fs/nfs/nfsroot.c, we have (after I applied the patch):
> > static const match_table_t tokens __initconst = {
> >         {Opt_port, "port=%u"},
> >         {Opt_rsize, "rsize=%u"},
> > 
> > It should probably be: 
> > static match_table_t tokens = {
> > 
> > (which is consistent with changes for super.c in your patch:
> >       +-static const match_table_t nfs_mount_option_tokens = {
> >       ++static match_table_t nfs_mount_option_tokens = {
> >  except that you also need to get rid of the "__initconst" keyword).
> > 
> > Please resolve this, and re-send the patch (and also check this for the 2.6.25 patch)
> > 
> > Did you actually compile the patch on kernel 2.6.22?
> 
> Yes, I even ran Connectathon to verify that it works...
> 
> Funny, I do not see this error on my setup.  I'll re-clone the git tree
> and apply the patches to verify I see the same error you do.

I still don't see it.  Maybe you can tell me what I'm doing wrong.  
Here are the steps I did:

I saved the patch into mbox named foo
# git pull
# git checkout -b sanity ofed_kernel_1_5
# git am -3 ~/foo
# git log 

It shows the patch in there..

# git clean -f
# git reset --hard HEAD
# git clean -f

The tree is now super clean

# ./ofed_scripts/ofed_makedist.sh
# scp ofed_kernel-2.6.22.tgz  root at vic12:

The kernel source is now on my victim system

On the victim:
# tar -xzvf ofed_kernel-2.6.22.tgz
# cd ofed_kernel-2.6.22
# ./configure --with-core-mod --with-user_mad-mod --with-user_access-mod --with-addr_trans-mod --with-mthca-mod --with-mlx4-mod --with-mlx4_en-mod --with-ipoib-mod --with-sdp-mod --with-nfsrdma-mod
# make install > /dev/null

The last one ouputs:
/root/ofed_kernel-2.6.22/drivers/infiniband/ulp/sdp/sdp_bcopy.c: In function ‘sdp_post_sends’:
/root/ofed_kernel-2.6.22/drivers/infiniband/ulp/sdp/sdp_bcopy.c:214: warning: unused variable ‘wc_processed’
WARNING: /root/ofed_kernel-2.6.22/lib/modules/2.6.22.19-smp/extra/drivers/infiniband/core/ib_addr.ko needs unknown symbol ip6_route_output
WARNING: /root/ofed_kernel-2.6.22/lib/modules/2.6.22.19-smp/extra/drivers/infiniband/core/ib_addr.ko needs unknown symbol ipv6_chk_addr
WARNING: /root/ofed_kernel-2.6.22/lib/modules/2.6.22.19-smp/extra/drivers/infiniband/ulp/ipoib/ib_ipoib.ko needs unknown symbol icmpv6_send

Do you see anything I did incorrectly?

Thanks,
Jon

> 
> thanks,
> Jon
> 
> > 
> > -Jack
> _______________________________________________
> ewg mailing list
> ewg at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg