[ewg] [PATCH] RHEL5 backport crypto.h and scatterlist.h cleanup

Vladimir Sokolovsky vlad at mellanox.co.il
Thu May 7 04:34:37 PDT 2009


>-----Original Message-----
>From: Jack Morgenstein [mailto:jackm at dev.mellanox.co.il] 
>Sent: Thursday, May 07, 2009 9:00 AM
>To: ewg at lists.openfabrics.org
>Cc: Jon Mason; Vladimir Sokolovsky; Tziporet Koren
>Subject: Re: [ewg] [PATCH] RHEL5 backport crypto.h and scatterlist.h
cleanup
>
>
>On Wednesday 06 May 2009 18:45, Jon Mason wrote:
>> Lustre is getting a struct redeinfition due to its declaration in the

>> Lustre header files as well as in the RHEL5 backports.  Fortunately, 
>> OFED can avoid defining the struct all together, as it already exists

>> in the base kernel's header files in ncrypto.h.  By using the 
>> ncrypto.h header file in the base kernel, it removes a significant 
>> amount of duplicate functionality already existing in crypto.h and 
>> scatterlist.h in the RHEL5.2 and RHEL5.3 backports.  Also, this 
>> functionality duplication can cause problems if both the OFED headers

>> and ncrypto.h are included in the same file.
>> 
>Looks very good, Jon!
>
>Vlad, please take this patch for ofed 1.4.1.
>
>- Jack

Applied,

Regards,
Vladimir 



More information about the ewg mailing list