[ewg] Crash in iw_cxgb3 (Chelsio) in OFED 1.4.1

Steve Wise swise at opengridcomputing.com
Wed Nov 4 21:49:54 PST 2009


Roland Dreier wrote:
> BTW Steve this BUG_ON() in the driver is pretty unfriendly... do we
> really need to kill the whole system just because the NIC went out to
> lunch?  Seems that the code to return an error and limp on is already
> there, if we just change the BUG_ON() to WARN().
>
>  - R.
>   

We can remove the BUG_ON() entirely and just return an error.   But 
perhaps we should mark the device as fatally wounded.  Lemme propose a 
patch...

Steve.






More information about the ewg mailing list