[ewg] ofa_1_5_kernel 20091104-0200 daily build status

[Jon Mason]

On Fri, Nov 20, 2009 at 08:49:16AM -0800, Jeff Becker wrote:
> Brian J. Murrell wrote:
> > On Fri, 2009-11-20 at 10:14 -0500, Brian J. Murrell wrote: 
> >   
> >> But it does mean usurping the possible definition of
> >> ipv6_addr_loopback() in the O/S for the one in OFED, for whatever that's
> >> worth.
> >>     
> >
> >   
> Actually - that's OK, since the problem arises from the fact that the
> backport file contains the definition because older versions of
> SLES10SP2 didn't. You're basically replacing the kernel header
> definition (in newer SLES10SP2 kernels) with the identical definition.
> 
> Jon - do you think we should have Vlad pull this patch?

It looks like a valid solution to the problem.  I don't see any reason
why he would reject it.  Have Brian push the patch (or I can commit it
to my tree and push it).

Thanks,
Jon

> 
> Thanks.
> 
> -jeff
> 
> 
> > And just to further reply to myself, this patch appears to do the job,
> > although I have to admit not being able to do any testing with ipv6 at
> > all:
> >
> > --- kernel_addons/backport/2.6.16_sles10_sp2/include/net/ipv6.h.old	2009-11-03 14:17:26.000000000 -0500
> > +++ kernel_addons/backport/2.6.16_sles10_sp2/include/net/ipv6.h	2009-11-20 10:23:12.000000000 -0500
> > @@ -18,10 +18,12 @@
> >  		(a->s6_addr32[2] ^ htonl(0x0000ffff))) == 0);
> >  }
> >  
> > -static inline int ipv6_addr_loopback(const struct in6_addr *a)
> > +static inline int __ipv6_addr_loopback(const struct in6_addr *a)
> >  {
> >  	return ((a->s6_addr32[0] | a->s6_addr32[1] |
> >  	         a->s6_addr32[2] | (a->s6_addr32[3] ^ htonl(1))) == 0);
> >  }
> >  
> > +#define ipv6_addr_loopback(a) __ipv6_addr_loopback(a)
> > +
> >  #endif
> >
> >   
>