[ewg] [PATCH 00/10] Add fcoe, fcoib drivers for mlx4 device

[Roland Dreier]

Unfortunately it will probably be a while before I can look at this in
any detail, but here are some obvious things to fix:

 - The actual FC/SCSI driver will need to be reviewed on
   linux-scsi at vger.kernel.org of course; so please CC that list.

 - The ordering/split of patches seems off; in particular I notice that
   the patch that adds the new drivers into the build system comes
   before the patch that actually adds the new drivers, which is
   obviously wrong (since the kernel will be broken if we apply patch
   9/10 but not 10/10).

 - None of the patch subjects contain a subject that says what part of
   the kernel they touch.  For example, instead of

    "[PATCH 01/10]  pre-reserve MPTs for FC"

   please write:

    "[PATCH 01/10] mlx4_core: Pre-reserve MPTs for FC"

   otherwise I waste time having to fix it up by hand.  (And also if you
   want to do things exactly write, please capitalize the subject but do
   not put in a final '.'  But I usually do not complain about that
   level of detail)

 - Every patch seems to have the changelog and diffstat twice.  Please
   fix (and include a "---" between the changelog and diffstat).  If you
   prepare a clean git tree, then git format-patch will get everything
   exactly correct.

 - There seem to be a lot of whitespace and other formatting problems.
   Please run patches through checkpatch.pl and fix any real problems
   that it finds (0 warnings are not necessary since some warnings are
   false positives; but I suspect for these patches most won't be).
-- 
Roland Dreier <rolandd at cisco.com> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html