[ewg] [PATCH] Handling busy responses from the SA

[Mike Heinz]

Roland Dreier said:

> I don't have a strong opinion on this but it seems a bit odd.  If we're just going to drop the response anyway, why did the SA send it in the first place?  On the other hand, if the SA told us it's busy, it does seem we could do something more sensible than retrying immediately.

The spec provides for the SA to return a BUSY response. When that happens, this patch causes us to wait for the original request to time out before retrying, not trying again immediately. In effect, we are pretending we never got the BUSY response and allowing the request to time out, instead.

Roland Dreier said:

> The indentation of values seems pretty crazy here.  Also I'm not sure what most of these defines are for?  They seem unused in this patch.

The indentation is probably from the conversion of tabs to spaces when the patch was pasted into the email - correcting it is no problem.  The value IB_MGMT_MAD_STATUS_BUSY is used in the patch, the others are defined because they are the other possible values for the same status field. We might as well define them all, for completeness.