[ewg] [GIT PULL ofed-1.5.1] iwcm fix for bug 1988

Steve Wise swise at opengridcomputing.com
Thu Mar 18 11:16:06 PDT 2010


Vlad,

Please pull from:

http://vlad@sofa.openfabrics.org/~swise/scm/ofed_kernel ofed_1_5


This one commit resolves bug 1988. This was upstream but I must have 
missed adding it into ofed.

Steve.



-------

commit 238dcbfb78f47952a42415b9a355af1a4e9e3acd
Author: Steve Wise <swise at opengridcomputing.com>
Date:   Thu Mar 18 10:06:53 2010 -0500

    RDMA/iwcm: Don't call provider reject func with irqs disabled
   
    Pull in this fix:
   
    RDMA/iwcm: Don't call provider reject func with irqs disabled
   
    In commit cb58160e ("RDMA/iwcm: Reject the connection when the cm_id
    is destroyed") a call to the provider's reject handler was added to
    destroy_cm_id() to fix a provider endpoint leak.  This call needs to
    be done with interrupts enabled.  So unlock and relock around this
    call.  This is safe because:
   
    1) the provider will do nothing with this endpoint until the iwcm
       either accepts or rejects.
    2) the lock is only released after the iwcm state is changed, so an
       errant iwcm app that is destroying -and- rejecting the connection
       concurrently will get a failure on one of the calls.
   
    Signed-off-by: Steve Wise <swise at opengridcomputing.com>
    Signed-off-by: Roland Dreier <rolandd at cisco.com>





More information about the ewg mailing list