[ewg] [PATCHv8 04/11] ib_core: IBoE CMA device binding

[Eli Cohen]

On Wed, May 12, 2010 at 01:03:42PM -0700, Roland Dreier wrote:
>  >  int ib_init_ah_from_path(struct ib_device *device, u8 port_num,
>  > -			 struct ib_sa_path_rec *rec, struct ib_ah_attr *ah_attr)
>  > +			 struct ib_sa_path_rec *rec, struct ib_ah_attr *ah_attr,
>  > +			 int force_grh)
> 
> Rather than this change in API, could we just have this function look at
> the link layer, and if it's ethernet, then always set the GRH flag?
> Seems simpler than requiring the upper layers to do this and then pass
> the result in?

I guess that would keep the function more versatile but changing the
implenetation to check the port's link layer seems OK to me.