[ewg] [PATCHv8 09/11] mlx4: Add support for IBoE - address resolution

Eli Cohen eli at dev.mellanox.co.il
Thu May 13 04:53:15 PDT 2010


On Wed, May 12, 2010 at 01:32:01PM -0700, Roland Dreier wrote:
>  > +	u8		mac_0_1[2];
>  > +	u8		mac_2_5[4];
> 
> This looks a bit odd.  Any reason why you don't just have "u8 mac[6];"
> in this structure?

We can get rid of this crap. I think the origin of this is a
limitation of ib_pack() to deal with fields that cross a dword
boundary which should not avoid us from using mac[6] here.



More information about the ewg mailing list