[ewg] FW: [PATCH] compat-rdma-3.5: Changes to makefile

[Vladimir Sokolovsky]

On 07/18/2012 01:08 AM, Nikolova, Tatyana E wrote:
> After testing OFED-3.5-20120716-0723 with linux-3.5.0-rc6, RHEL 6.2, RHEL 6.3 and SLES 11-SP2, it appears that CONFIG_COMPAT_SKB_FRAG_NEEDED is always undefined when building compat-rdma-3.5, which results in build errors for RHEL 6.2 and SLES 11-SP2.
>
> The change to the makefile is a suggested fix. It is up to you how/where to define CONFIG_COMPAT_SKB_FRAG_NEEDED
>
> Sorry, if I sent the patch more than once, I don't see it in openfabrics mailing list
>
> Thanks,
> Tatyana


Hi Tatiana,
I applied the following patch to fix this issue:

diff --git a/makefile b/makefile
index 7f51d3f..8d04b9c 100644
--- a/makefile
+++ b/makefile
@@ -24,8 +24,17 @@ CFLAGS += \

  ifneq ($(CONFIG_COMPAT_SLES_11_2),)
  CFLAGS += \
-       -DCONFIG_COMPAT_SLES_11_2=$(CONFIG_COMPAT_SLES_11_2) \
-       -DNEED_MIN_DUMP_ALLOC_ARG=$(NEED_MIN_DUMP_ALLOC_ARG)
+       -DCONFIG_COMPAT_SLES_11_2
+endif
+
+ifneq ($(NEED_MIN_DUMP_ALLOC_ARG),)
+CFLAGS += \
+       -DNEED_MIN_DUMP_ALLOC_ARG
+endif
+
+ifneq ($(CONFIG_COMPAT_SKB_FRAG_NEEDED),)
+CFLAGS += \
+       -DCONFIG_COMPAT_SKB_FRAG_NEEDED
  endif

  DEPMOD  = /sbin/depmod


Regards,
Vladimir

>
> -----Original Message-----
> From: Nikolova, Tatyana E
> Sent: Tuesday, July 17, 2012 4:43 PM
> Subject: [PATCH] compat-rdma-3.5: Changes to makefile
>
> CONFIG_COMPAT_SKB_FRAG_NEEDED is defined in the makefile.
> It is necessary for kernels < linux-3.2 except for RHEL 6.3 (linux-2.6.32-279.el6) where CONFIG_COMPAT_SKB_FRAG_NEEDED should not be defined.
>
> Signed-off-by: Tatyana Nikolova <Tatyana.E.Nikolova at intel.com>
> ---
>   makefile |    7 +++++++
>   1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/makefile b/makefile
> index 19a668c..d609f23 100644
> --- a/makefile
> +++ b/makefile
> @@ -54,6 +54,12 @@ ifneq ($(kconfig_h),)
>   KCONFIG_H = -include $(kconfig_h)
>   endif
>
> +#ifdef CONFIG_COMPAT_KERNEL_3_2
> +ifneq ("$(KVERSION)","2.6.32-279.el6.x86_64")
> +COMPAT_3_2_SKB_FRAG = 1
> +endif
> +#endif
> +
>   V ?= 1
>
>   #########################
> @@ -137,6 +143,7 @@ kernel:
>   		-I$(CWD)/drivers/infiniband/ulp/srpt \
>   		$$(if $$(CONFIG_XEN),-D__XEN_INTERFACE_VERSION__=$$(CONFIG_XEN_INTERFACE_VERSION)) \
>   		$$(if $$(CONFIG_XEN),-I$$(srctree)/arch/x86/include/mach-xen) \
> +		$$(if $$(COMPAT_3_2_SKB_FRAG),-DCONFIG_COMPAT_SKB_FRAG_NEEDED) \
>   		-I$$(srctree)/arch/$$(SRCARCH)/include \
>   		-Iarch/$$(SRCARCH)/include/generated -Iinclude \
>   		$$(if $$(KBUILD_SRC),-Iinclude2 -I$$(srctree)/include) \
>