[ewg] Build errors while trying to build iw_cxgb3 and iw_cxgb4 drivers together

[Steve Wise]

Hey vipul, I recall us having to make a change to the cxgb3/cxgb4 
makefiles so that they included the correct header files, because they 
both have the same names, like l2t.h.    If you look at the ofed-1.5.4 
tree I think you'll see this.


On 5/3/2012 1:50 PM, Vipul Pandya wrote:
>
>
> On 03-May-2012, at 11:08 PM, Vladimir Sokolovsky<vlad at dev.mellanox.co.il>  wrote:
>
>> On 05/03/2012 05:42 PM, Vipul Pandya wrote:
>>> Hi Vlad,
>>>
>>>
>>>
>>> I am getting a build failure while building cxgb3 and cxgb4 drivers together. The errors are coming because of wrong inclusion of header files. To be precise it includes cxgb3 header files while trying to compile iw_cxgb4 driver. Due to this I am getting following build failure.
>>>
>>>
>>>
>>> =====
>>>
>>> gcc -Wp,-MD,/root/ofed_git_tree/compat-rdma/drivers/infiniband/hw/cxgb4/.cm.o.d  -nostdinc -isystem /usr/lib/gcc/x86_64-redhat-linux/4.4.6/include \
>>>
>>> -D__OFED_BUILD__ \
>>>
>>> -DCOMPAT_BASE_TREE="\"linux-3.2.git\"" -DCOMPAT_BASE_TREE_VERSION="\"v3.2\"" -DCOMPAT_PROJECT="\"Compat-rdma\"" -DCOMPAT_VERSION="\"8afafc8\""  \
>>>
>>> -include /lib/modules/2.6.32-220.el6.x86_64/build/include/linux/autoconf.h \
>>>
>>> -include /root/ofed_git_tree/compat-rdma/include/linux/autoconf.h \
>>>
>>> \
>>>
>>> -include /root/ofed_git_tree/compat-rdma/include/linux/compat-2.6.h \
>>>
>>> \
>>>
>>> \
>>>
>>> \
>>>
>>> \
>>>
>>> -I/root/ofed_git_tree/compat-rdma/include \
>>>
>>> -I/root/ofed_git_tree/compat-rdma/drivers/infiniband/debug \
>>>
>>> -I/usr/local/include/scst \
>>>
>>> -I/root/ofed_git_tree/compat-rdma/drivers/infiniband/ulp/srpt \
>>>
>>> -I/root/ofed_git_tree/compat-rdma/drivers/net/ethernet/chelsio/cxgb3 \
>>>
>>> -I/root/ofed_git_tree/compat-rdma/drivers/net/ethernet/chelsio/cxgb4 \
>>>
>>> -D__XEN_INTERFACE_VERSION__= \
>>>
>>> -I/usr/src/kernels/2.6.32-220.el6.x86_64/arch/x86/include/mach-xen \
>>>
>>> -I/usr/src/kernels/2.6.32-220.el6.x86_64/arch/x86/include \
>>>
>>> -Iarch/x86/include/generated -Iinclude \
>>>
>>> \
>>>
>>> -I/usr/src/kernels/2.6.32-220.el6.x86_64/arch/x86/include \
>>>
>>> -D__KERNEL__ -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -Werror-implicit-function-declaration -Wno-format-security -fno-delete-null-pointer-checks -O2 -m64 -mtune=generic -mno-red-zone -mcmodel=kernel -funit-at-a-time -maccumulate-outgoing-args -fstack-protector -DCONFIG_AS_CFI=1 -DCONFIG_AS_CFI_SIGNAL_FRAME=1 -pipe -Wno-sign-compare -fno-asynchronous-unwind-tables -mno-sse -mno-mmx -mno-sse2 -mno-3dnow -Wframe-larger-than=2048 -Wno-unused-but-set-variable -fno-omit-frame-pointer -fno-optimize-sibling-calls -g -pg -Wdeclaration-after-statement -Wno-pointer-sign -fno-strict-overflow -fno-dwarf2-cfi-asm -fconserve-stack -I/root/ofed_git_tree/compat-rdma/drivers/net/ethernet/chelsio/cxgb4  -DMODULE -D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(cm)"  -D"KBUILD_MODNAME=KBUILD_STR(iw_cxgb4)" -D"DEBUG_HASH=22" -D"DEBUG_HASH2=43" -c -o /root/ofed_git_tree/compat-rdma/drivers/infiniband/hw/cxgb4/.tmp_cm.o /root/ofed_git_tree/compat-rdma/dr
>> ivers/infiniband/hw/cxgb4/cm.c
>>> /root/ofed_git_tree/compat-rdma/drivers/infiniband/hw/cxgb4/cm.c: In function âc4iw_l2t_sendâ:
>>>
>>> /root/ofed_git_tree/compat-rdma/drivers/infiniband/hw/cxgb4/cm.c:173: error: implicit declaration of function âcxgb4_l2t_sendâ
>>>
>>> /root/ofed_git_tree/compat-rdma/drivers/infiniband/hw/cxgb4/cm.c: In function â_c4iw_free_epâ:
>>>
>>> /root/ofed_git_tree/compat-rdma/drivers/infiniband/hw/cxgb4/cm.c:268: error: implicit declaration of function âcxgb4_l2t_release
>>>
>>>
>>>
>>> =====
>>>
>>>
>>>
>>> cxgb4_l2t_send function is declared in l2t.h file. This l2t.h file is present in both cxgb3 as well as cxgb4 directories. Since in above command cxgb3 path is included first, l2t.h file also gets included from there. If I include cxgb4 path first then this error is not coming.
>>>
>>>
>>>
>>> Please suggest how should I go to fix this?
>>>
>>>
>>>
>>> Thanks,
>>>
>>> Vipul
>>>
>>>
>> Hi Vipul,
>> Please refer to the following email for the backpoting instructions: http://web.archiveorange.com/archive/v/8BSVw1dy9TMJxitRze4Z
>>
>> Regards,
>> Vladimir
> Hi Vlad,
>
> I have gone through this mail chain and followed the instructions specified. I have cloned all three repos, exported those environment variables and run admin_rdma.sh script to get the ofa_kernel tree.
>
> After this i configured the ofa_kernel with --with-cxgb3 --with-cxgb4 options. Then executed make command and ended up in above build failure.
>
> Thanks,
> Vipul