[ewg] [GIT PULL OFED-3.2] cxgb3/cxgb4/iw_cxgb3/iw_cxgb4backports

Vipul Pandya vipul at chelsio.com
Tue May 22 06:01:25 PDT 2012



-----Original Message-----
From: Marciniszyn, Mike [mailto:mike.marciniszyn at intel.com] 
Sent: 21 May 2012 22:08
To: Vipul Pandya
Cc: Kumar A S; Abhishek Agrawal; ewg at lists.openfabrics.org; Divy Le Ray;
Vladimir Sokolovsky
Subject: RE: [ewg] [GIT PULL OFED-3.2]
cxgb3/cxgb4/iw_cxgb3/iw_cxgb4backports

Vipul,

I noticed that this patch gets a build failure for cxgb4 on SLES11SP2
with the current compat, compat-rdma, and linux-3.2 trees.

There is an API difference between SLES11SP2 and 3.0.13 with
__netdev_alloc_page() taking one more argument:

SLES11SP2:
struct page *_netdev_alloc_page(struct net_device, gfp_t, struct sk_buff
*)

3.0.13:
struct page *_netdev_alloc_page(struct net_device, gfp_t)

The cxgb4 driver builds for everything else.

How do you want to fix this?

[VIPUL] I have seen in your pull message that you have already fixed
this thing. Thank you for this. However I see that it has been fixed in
upstream Linux by commit 1f2149c1df50c8c712950872675f46e6e44629f0. This
commit does couple of additional changes apart from what you have done.
I would like this to fix the same way. Once your commits are pulled I
will do the necessary changes. 

This is the second API different I've seen with SLES11SP2.   The first
was in the netlink_dump_start() used in core/netlink.c.

I'm suspecting that a distinct backport branch is needed for SLES11SP2,
which I have in a patch to add that to fix the netlink_dump_start()
difference.

Mike





More information about the ewg mailing list