[ewg] [PULL][OFED 3.18] 7.1 compat patches for OFED BZ 2531

Vladimir Sokolovsky vlad at dev.mellanox.co.il
Wed Apr 15 23:10:51 PDT 2015


On 15/04/15 18:56, Marciniszyn, Mike wrote:
>> On 15/04/15 16:12, Marciniszyn, Mike wrote:
>>> Please pull from these fixes from ~mmarciniszyn/scm/new_ofed/compat from
>> the for-ofed-3.18 branch:
>>>
>>> commit 52df7d8c70400e3eefb946f99a4886719e15552e
>>> Author: Mike Marciniszyn <mike.marciniszyn at intel.com>
>>> Date:   Wed Apr 15 08:54:34 2015 -0400
>>>
>>>       compat: detect cpumask_set_cpu_local_first
>>>
>>>       RHEL 7.1 exports cpumask_set_cpu_local_first.  compat's
>>>       autoconf needs to detect and avoid the duplicate
>>>       symbol.
>>>
>>>       This addresses OFED BZ 2531.
>>>
>>>       Signed-off-by: Mike Marciniszyn <mike.marciniszyn at intel.com>
>>>
>>
>> Hi Mike,
>> I pushed another fix for this issue already:
>
>> +#define cpumask_set_cpu_local_first
>> +LINUX_BACKPORT(cpumask_set_cpu_local_first)
>>    int cpumask_set_cpu_local_first(int i, int numa_node, cpumask_t *dstp)
>>    {
> Won't this avoid using the base kernel routine in all cases?
>
> It would seem to me that using the base kernel version is the best approach...
>
> Mike
>

Hi Mike,
In general, you are right, but in this case compat implementation is the same as kernel's one.

Regards,
Vladimir



More information about the ewg mailing list