[ewg] SLES12SP2 build error

[Vladimir Sokolovsky]

On 08/26/2017 12:42 AM, Jeff Becker wrote:
> On 08/25/2017 02:23 PM, Jeff Becker wrote:
>> On 08/25/2017 02:15 PM, Vladimir Sokolovsky wrote:
>>> On 08/25/2017 11:56 PM, Jeff Becker wrote:
>>>> Hi Vlad,
>>>>
>>>> OFED4.8-1 (including NFS/RDMA) builds fine on RHEL7.3. However, on 
>>>> SLES12SP2, I get the error below. Note that the initial warning 
>>>> about the extra CONFIG_QED token happens on RHEl7.3 as well.
>>>>
>>>> Thanks for your help.
>>>>
>>>> -jeff
>>>>
>>>> # ./configure --with-core-mod --with-user_mad-mod 
>>>> --with-user_access-mod --with-addr_trans-mod --with-mlx4-mod 
>>>> --with-ipoib-mod --with-nfsrdma-mod
>>>> # make
>>>>
>>>
>>> Hi Jeff,
>>> I removed the extra CONFIG_QED yesterday. Please rebase your git 
>>> branch.
>>
>> This morning I did:
>>
>> % cd compat-rdma
>> % git checkout master
>> % git pull (got your new configure)
>> % git checkout nfsrdma
>> % git merge master
>>
>> Does this not work?
>>
>>> To avoid compilation issue with Broadcom drivers add to your 
>>> configure command: --without-bnxt_re-mod --without-bnxt_en-mod
>>> They are still working on backports...
>
> I tried adding those at the end of my configure command line, and I 
> still get the error. Do they need to be in a certain order, e.g., 
> before with-mlx4-mod --with-ipoib-mod
>
> -jeff

The patch below should help. You can re-base your git tree to get one:

diff --git a/makefile b/makefile
index 95bc522..9b16680 100644
--- a/makefile
+++ b/makefile
@@ -159,6 +159,7 @@ kernel: $(COMPAT_CONFIG) $(COMPAT_AUTOCONF)
                 CONFIG_QED_LL2=$(CONFIG_INFINIBAND_QEDR) \
                 CONFIG_QED_RDMA=$(CONFIG_INFINIBAND_QEDR) \
                 CONFIG_INFINIBAND_QEDR=$(CONFIG_INFINIBAND_QEDR) \
+               CONFIG_BNXT=$(CONFIG_BNXT) \
CONFIG_INFINIBAND_BNXT_RE=$(CONFIG_INFINIBAND_BNXT_RE) \
                 LINUXINCLUDE=' \
                 -D__OFED_BUILD__ \


Regards,
Vladimir


>>
>> OK. Thanks.
>>
>> -jeff
>>>
>>> Regards,
>>> Vladimir
>>>
>>>> ...
>>>>
>>>>   CC [M] 
>>>> /root/jcbecker/OFED4.8-1/compat-rdma/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.o
>>>> In file included from 
>>>> /lib/modules/4.4.59-92.24-default/source/include/linux/kconfig.h:4:0,
>>>>                  from <command-line>:0:
>>>> /root/jcbecker/OFED4.8-1/compat-rdma/include/generated/autoconf.h:167:19: 
>>>> warning: extra tokens at end of #undef directive [enabled by default]
>>>>  #undef CONFIG_QED CONFIG_QED
>>>>                    ^
>>>> /root/jcbecker/OFED4.8-1/compat-rdma/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c: 
>>>> In function ‘bnxt_grxclsrule’:
>>>> /root/jcbecker/OFED4.8-1/compat-rdma/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:550:18: 
>>>> error: ‘struct flow_keys’ has no member named ‘ip_proto’
>>>>          if (fkeys->ip_proto == IPPROTO_TCP)
>>>>                   ^
>>>> /root/jcbecker/OFED4.8-1/compat-rdma/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:552:23: 
>>>> error: ‘struct flow_keys’ has no member named ‘ip_proto’
>>>>          else if (fkeys->ip_proto == IPPROTO_UDP)
>>>>                        ^
>>>> /root/jcbecker/OFED4.8-1/compat-rdma/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:557:44: 
>>>> error: ‘struct flow_keys’ has no member named ‘src’
>>>>          fs->h_u.tcp_ip4_spec.ip4src = fkeys->src;
>>>>                                             ^
>>>> /root/jcbecker/OFED4.8-1/compat-rdma/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:560:44: 
>>>> error: ‘struct flow_keys’ has no member named ‘dst’
>>>>          fs->h_u.tcp_ip4_spec.ip4dst = fkeys->dst;
>>>>                                             ^
>>>> /root/jcbecker/OFED4.8-1/compat-rdma/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:563:42: 
>>>> error: ‘struct flow_keys’ has no member named ‘port16’
>>>>          fs->h_u.tcp_ip4_spec.psrc = fkeys->port16[0];
>>>>                                           ^
>>>> /root/jcbecker/OFED4.8-1/compat-rdma/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:566:42: 
>>>> error: ‘struct flow_keys’ has no member named ‘port16’
>>>>          fs->h_u.tcp_ip4_spec.pdst = fkeys->port16[1];
>>>>                                           ^
>>>> /usr/src/linux-4.4.59-92.24/scripts/Makefile.build:259: recipe for 
>>>> target 
>>>> '/root/jcbecker/OFED4.8-1/compat-rdma/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.o' 
>>>> failed
>>>>
>>>
>>
>