[ewg] [GIT PULL compat-rdma] qib for OFED 4.8

[Davis, Arlin R]

It seems like we now have a way to apply the latest SRP upstream fixes to OFED 4.8, tested with RH 7.2 and RH7.3. However, we still have 2 critical bugs (1 new one) on RH 7.2 even after the upstream fixes are applied. RH 7.3+OFED4.8+srp_backport seems to be fine.

http://bugs.openfabrics.org/show_bug.cgi?id=2632
http://bugs.openfabrics.org/show_bug.cgi?id=2634

How does DDN want to proceed? 
Is it acceptable to apply upstream version/fixes to OFED 4.8 as follow, document in release notes?
Can you tell us if the remaining bugs are related to OFED 4.8 or if RH7.2+infiniband+srp_backport has the same issues?  

The ib_srp-backport procedure is as follows:
1. Install the OS (RHEL, SLES, ...).
2. Install OFED.
3. Install the ib_srp-backport driver:
	git clone https://github.com/bvanassche/ib_srp-backport
	cd ib_srp-backport
	make rpm
	sudo rpm -U $PWD/rpmbuilddir/RPMS/*/*.rpm

Thanks, 

Arlin

> SRP is included already in OFED-4.8 as a part of linux-4.8 kernel and I don't
> see any reason to include SRP code twice.
> If some bug fixes have to be added there then there is a specific place in
> compat-rdma git tree for the relevant patches.
> If somebody is interested to add an additional SRP standalone package then
> please send me the relevant patches for compat-rdma/ofed_scripts and build
> git trees.
> 
> Regards,
> Vladimir
> 
> 
> On 06/20/2017 09:01 PM, Davis, Arlin R wrote:
> > Ok. Vlad, what would it take to get this backported version of SRP into OFED
> 4.8?
> >
> >> -----Original Message-----
> >> From: Bart Van Assche [mailto:Bart.VanAssche at wdc.com]
> >> Sent: Tuesday, June 20, 2017 10:49 AM
> >> To: vlad at dev.mellanox.co.il; rsdance at soft-forge.com; Davis, Arlin R
> >> <arlin.r.davis at intel.com>; Hanania, Amir <amir.hanania at intel.com>;
> >> Woodruff, Robert J <robert.j.woodruff at intel.com>; mschlining at ddn.com
> >> Cc: ewg at lists.openfabrics.org; cfernandes at ddn.com; mdavis at ddn.com
> >> Subject: Re: [ewg] [GIT PULL compat-rdma] qib for OFED 4.8
> >>
> >> Hello Arlin,
> >>
> >> Adding a URL to the OFED README is not the same as including a
> >> version of the ib_srp-backport driver in OFED. How can OFED users
> >> know what version of the ib_srp-backport driver has been tested in
> >> combination with which OFED version?
> >>
> >> Thanks,
> >>
> >> Bart.
> >>
> >> On Tue, 2017-06-20 at 17:18 +0000, Davis, Arlin R wrote:
> >>> Marty,
> >>>
> >>> Would this work for DDN? We could add the URL and the SRP backport
> >>> readme to the OFED release notes. I believe you had an issue when
> >>> applying the backport to SL 7.2 and OFED 4.8 RC4 but I think Bart
> >>> fixed that
> >> already.
> >>> Thanks, Arlin
> >>>
> >>>> Hello Arlin and Robert,
> >>>>
> >>>> A backported version of the 4.11 ib_srp driver that already has
> >>>> been tested is available at https://github.com/bvanassche/ib_srp-
> backport.
> >>>> That driver builds fine against kernel.org kernels, RHEL/CentOS
> >>>> kernels, openSuSE and SLES kernels and also against MOFED and OFED.
> >>>> Has it already been considered to use that code base instead of
> >>>> duplicating the backporting effort of the ib_srp driver?
> >>>>
> >>>> Thanks,
> >>>>
> >>>> Bart.