[openib-general] ib_req_ncomp_notif in core_ layer

[Michael S. Tsirkin]

Hello, Grant!
Quoting r. Grant Grundler (iod00d at hp.com) "Re: [openib-general] ib_req_ncomp_notif in core_ layer":
> On Wed, Aug 04, 2004 at 11:41:38AM +0300, Michael S. Tsirkin wrote:
> > Why cant all users just do device->req_ncomp_notif(cq, wc_cnt) directly?
> 
> It's useful to hide the indirect function call with either static inline
> or a macro.
But req_ncomp_notif is not inline, nor is it a macro.

> This reduces programming errors, hides the "method" used
> to access the indirect function and defines the "API" for a layer of code.

I do see a problem though
since each new method has to be added in multiple places - I count 4:
core header, core implementation, device structure, specific implementation.

Thanks,
mst