[openib-general] [PATCH] gen2: Only include CM and DM client in kernel build when needed

[Roland Dreier]

I like this idea (although I might want to hide this level of control
unless CONFIG_EMBEDDED is selected).  I think this sort of thing in
Makefiles is not the right way to go, though:

    +ifdef CONFIG_INFINIBAND_CM
    +obj-$(CONFIG_INFINIBAND) +=  \
    +    ib_cm.o
    +endif 

I think it would be better just to assign to
obj-$(CONFIG_INFINIBAND_CM).

Also, this is definitely not needed (if ib_cm.o isn't being build,
ib_cm-objs will just be ignored):

    +ifdef CONFIG_INFINIBAND_CM
     ib_cm-objs := \
         cm_main.o \
         cm_api.o \
    @@ -64,6 +73,7 @@
         cm_connection_table.o \
         cm_service_table.o \
         cm_proc.o
    +endif

Also I'm not sure that one needs both the "select" and "default y"
stuff in Kconfig.

I'd rather work this out later when we know what's in the real gen2
tree and how the core IPoIB stuff for merging upstream looks.  Then we
can figure out how to add CM, etc.  (And see if we can move DM into
userspace)

 - R.