[openib-general] [PATCH]: GSI: Eliminate function declaration isn't a prototype warnings
Hal Rosenstock
halr at voltaire.com
Sat Aug 7 15:44:07 PDT 2004
Eliminate function declaration isn't a prototype warnings
Index: gsi_main.c
===================================================================
--- gsi_main.c (revision 596)
+++ gsi_main.c (working copy)
@@ -178,8 +178,8 @@
*hca, u32 client_id);
static void gsi_put_class_info(struct gsi_serv_class_info_st *class_info);
-static void gsi_get_all_classes();
-static void gsi_put_all_classes();
+static void gsi_get_all_classes(void);
+static void gsi_put_all_classes(void);
static void gsi_send_compl_cb(struct gsi_hca_info_st *hca,
struct gsi_dtgrm_priv_st *dtgrm_priv);
@@ -1032,7 +1032,7 @@
* Increase reference counter for all classes
*/
static void
-gsi_get_all_classes()
+gsi_get_all_classes(void)
{
struct gsi_serv_class_info_st *class_info, *head =
(struct gsi_serv_class_info_st *) &gsi_class_list;
@@ -1049,7 +1049,7 @@
* Decrease reference counter for all classes
*/
static void
-gsi_put_all_classes()
+gsi_put_all_classes(void)
{
struct gsi_serv_class_info_st *class_info, *head =
(struct gsi_serv_class_info_st *) &gsi_class_list;
@@ -1292,7 +1292,7 @@
* (see gsi_sent_dtgrm_timer_handler() description)
*/
static inline void
-gsi_sent_dtgrm_timer_run()
+gsi_sent_dtgrm_timer_run(void)
{
if (!atomic_dec_and_test(&gsi_sent_dtgrm_timer_running)) {
printk(KERN_DEBUG "Timer already running\n");
@@ -1311,7 +1311,7 @@
* Stop the sent datagram timer.
*/
static inline void
-gsi_sent_dtgrm_timer_stop()
+gsi_sent_dtgrm_timer_stop(void)
{
if (atomic_dec_and_test(&gsi_sent_dtgrm_timer_running)) {
printk(KERN_DEBUG "Timer not running\n");
@@ -2388,7 +2388,7 @@
* Print statistics to console
*/
static void
-gsi_proc_show_statistics()
+gsi_proc_show_statistics(void)
{
struct gsi_serv_class_info_st *class_info, *head =
(struct gsi_serv_class_info_st *) &gsi_class_list;
Index: rmpp/rmpp.c
===================================================================
--- rmpp/rmpp.c (revision 560)
+++ rmpp/rmpp.c (working copy)
@@ -211,7 +211,7 @@
* Get a send handling structure.
*/
struct rmpp_mad_send_t *
-__get_mad_send()
+__get_mad_send(void)
{
struct rmpp_mad_send_t *h_send;
@@ -745,7 +745,8 @@
/*
* Send the MAD.
- * If we failed to send, just free all send requests from the queue.
+ * If we failed to send, just free all
+ * send requests from the queue.
*/
if (status == RMPP_IB_SUCCESS)
status =
@@ -1562,8 +1563,7 @@
/*
* If a send tracking structure was already
- * created by sender rmpp_send(),
- * return it.
+ * created by sender rmpp_send(), return it.
* If not, create it and return NULL.
* Sender will use it later.
*/
Index: rmpp/rmpp_al.h
===================================================================
--- rmpp/rmpp_al.h (revision 560)
+++ rmpp/rmpp_al.h (working copy)
@@ -212,9 +212,9 @@
RMPP_IB_INVALID_MCAST_HANDLE,
RMPP_IB_INVALID_CALLBACK,
RMPP_IB_INVALID_AL_HANDLE, /* InfiniBand Access Layer */
- RMPP_IB_INVALID_HANDLE, /* InfiniBand Access Layer */
- RMPP_IB_ERROR, /* InfiniBand Access Layer */
- RMPP_IB_REMOTE_ERROR, /* Infiniband Access Layer */
+ RMPP_IB_INVALID_HANDLE, /* InfiniBand Access Layer */
+ RMPP_IB_ERROR, /* InfiniBand Access Layer */
+ RMPP_IB_REMOTE_ERROR, /* Infiniband Access Layer */
RMPP_IB_VERBS_PROCESSING_DONE, /* See Notes above */
RMPP_IB_INVALID_WR_TYPE,
RMPP_IB_QP_IN_TIMEWAIT,
@@ -262,15 +262,14 @@
struct rmpp_mad_send_t *h_send;
- struct rmpp_ib_mad_t *p_mad_buf; /* The buffer including
+ struct rmpp_ib_mad_t *p_mad_buf; /*
+ * Buffer including
* MAD header and payload.
* May be longer than 265
*/
u32 size;
- struct ib_rmpp_mad_seg_t mad_seg; /* 256 byte long
- * MAD segment
- */
+ struct ib_rmpp_mad_seg_t mad_seg; /* 256 byte long MAD segment */
u32 remote_qp;
@@ -300,11 +299,13 @@
u8 hop_limit;
u8 sgid_index;
- int dir_switch_needed; /* Sender will need to wait for an ACK
+ int dir_switch_needed; /*
+ * Sender will need to wait for an ACK
* before start sending.
* Set by RMPP service user.
*/
- u32 payload_offset; /* SA packets may need to
+ u32 payload_offset; /*
+ * SA packets may need to
* add SA header in every
* segment
*/
More information about the general
mailing list