[openib-general] modify_device API?

[Hal Rosenstock]

On Tue, 2004-08-17 at 13:23, Sean Hefty wrote:
> On Tue, 17 Aug 2004 09:54:06 -0700
> Sean Hefty <mshefty at ichips.intel.com> wrote:
> > I will update and commit these changes.  I want to convert the ib_port_cap_flags to match bit locations defined by the PortInfo attribute.  (E.g. IB_PORT_SM = (1<<31).)
> 
> Changes have been committed.

I found 2 minor issues with this change:
ib_verbs.h:261: conflicting types for `IB_DEVICE_SYS_IMAGE_GUID'
ib_verbs.h:138: previous declaration of `IB_DEVICE_SYS_IMAGE_GUID'

and line 782 should be device->modify_port rather than modify_device

Here's a patch for the latter:
Index: ib_verbs.h
===================================================================
--- ib_verbs.h	(revision 660)
+++ ib_verbs.h	(working copy)
@@ -778,8 +778,8 @@
 				 int port_modify_mask,
 				 struct ib_port_modify *port_modify)
 {
-	return device->modify_device(device, port_num, port_modify_mask,
-				     port_modify);
+	return device->modify_port(device, port_num, port_modify_mask,
+				   port_modify);
 }
 
 static inline struct ib_pd *ib_alloc_pd(struct ib_device *device)



> 
> _______________________________________________
> openib-general mailing list
> openib-general at openib.org
> http://openib.org/mailman/listinfo/openib-general
> 
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general