[openib-general] Re: [PATCH] remove ts_kernel_trace from client_query*

[Michael S. Tsirkin]

Quoting r. Roland Dreier (roland at topspin.com) "[openib-general] Re: [PATCH] remove ts_kernel_trace from client_query*":
>     Tom> So, would this be a per module variable?  So, there would be
>     Tom> like 10 or 15 parameters to set?
> 
>     Tom> Or would this be set in the base module that provides the
>     Tom> debug printing and everyone would be affected?
> 
> I would say per-module, although there would probably end up being a
> fair number of parameters.  Someone could easily write a userspace
> wrapper to make a nice interface to debuglevel setting though.
> 
> The reason I don't like having it in a base module is that it doesn't
> let you just turn on one module's tracing -- eg if I'm debugging
> IPoIB, I just want IPoIB tracing.
> 
>  - Roland

Wouldnt compile-time be enough?
If you want to change the setting,
you could just add -DDEBUG or something in the makefile and rebuild the
relevant module.

I'm not sure multiple debug levels are really useful - from experience
its hard to define in which debug level each print belongs,
so you end up enabling the maximum verbosity, anyway.

MST