[openib-general] Re: [PATCH] ib_mad.h: Add in IB management class definitions

[Sean Hefty]

On Tue, 31 Aug 2004 17:39:37 -0400
Hal Rosenstock <halr at voltaire.com> wrote:

> ib_mad.h: Add in IB management class definitions
> Vendor and application class definitions are still pending.

Thanks!  I've integrated into my working repository, but some nit-picky comments below...
 
> +/* Management classes */
> +#define IB_MGMT_CLASS_PERF                     0x04
> +#define IB_MGMT_CLASS_BM                       0x05
> +#define IB_MGMT_CLASS_DEV_MGT                  0x06
> +#define IB_MGMT_CLASS_COM_MGT                  0x07

I've gone back and forth on the names here.  The names closest to the spec would be what you have: PERF, BM, DEV_MGT, and COM_MGT.  For API consistency, we use MGMT, instead of MGT, and DEVICE instead of DEV.  And I'm guessing that the resulting CM API will use "cm" or "conn" in its name.  Anyway, I'm inclined to go with: PERF_MGMT (or PM), BM, DEVICE_MGMT (or DM), and CM.  Does anyone care or have an opinion?